Skip to content

Commit 37e6da6

Browse files
committed
refactor(router): clean up naming
1 parent 8aa2a0c commit 37e6da6

18 files changed

Lines changed: 326 additions & 89 deletions

modules/@angular/router/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,16 @@
77
*/
88

99

10-
export {ExtraOptions, provideRoutes, provideRouterConfig} from './src/common_router_providers';
11-
export {Data, ResolveData, Route, RouterConfig} from './src/config';
10+
export {ExtraOptions, provideRouterConfig, provideRoutes} from './src/common_router_providers';
11+
export {Data, ResolveData, Route, RouterConfig, Routes} from './src/config';
1212
export {RouterLink, RouterLinkWithHref} from './src/directives/router_link';
1313
export {RouterLinkActive} from './src/directives/router_link_active';
1414
export {RouterOutlet} from './src/directives/router_outlet';
1515
export {CanActivate, CanDeactivate, Resolve} from './src/interfaces';
1616
export {Event, NavigationCancel, NavigationEnd, NavigationError, NavigationStart, Router, RoutesRecognized} from './src/router';
17+
export {ROUTER_DIRECTIVES, RouterAppModule} from './src/router_app_module';
1718
export {RouterOutletMap} from './src/router_outlet_map';
1819
export {provideRouter} from './src/router_providers';
1920
export {ActivatedRoute, ActivatedRouteSnapshot, RouterState, RouterStateSnapshot} from './src/router_state';
2021
export {PRIMARY_OUTLET, Params} from './src/shared';
21-
export {RouterAppModule, ROUTER_DIRECTIVES} from './src/router_app_module';
2222
export {DefaultUrlSerializer, UrlPathWithParams, UrlSerializer, UrlTree} from './src/url_tree';

modules/@angular/router/src/apply_redirects.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {Observer} from 'rxjs/Observer';
1515
import {of } from 'rxjs/observable/of';
1616
import {EmptyError} from 'rxjs/util/EmptyError';
1717

18-
import {Route, RouterConfig} from './config';
18+
import {Route, Routes} from './config';
1919
import {RouterConfigLoader} from './router_config_loader';
2020
import {PRIMARY_OUTLET} from './shared';
2121
import {UrlPathWithParams, UrlSegment, UrlTree} from './url_tree';
@@ -38,7 +38,7 @@ function absoluteRedirect(newPaths: UrlPathWithParams[]): Observable<UrlSegment>
3838
}
3939

4040
export function applyRedirects(
41-
configLoader: RouterConfigLoader, urlTree: UrlTree, config: RouterConfig): Observable<UrlTree> {
41+
configLoader: RouterConfigLoader, urlTree: UrlTree, config: Routes): Observable<UrlTree> {
4242
return expandSegment(configLoader, config, urlTree.root, PRIMARY_OUTLET)
4343
.map(rootSegment => createUrlTree(urlTree, rootSegment))
4444
.catch(e => {
@@ -190,8 +190,8 @@ function matchPathsWithParamsAgainstRoute(
190190
function getChildConfig(configLoader: RouterConfigLoader, route: Route): Observable<Route[]> {
191191
if (route.children) {
192192
return of (route.children);
193-
} else if (route.mountChildren) {
194-
return configLoader.load(route.mountChildren).map(r => {
193+
} else if (route.loadChildren) {
194+
return configLoader.load(route.loadChildren).map(r => {
195195
(<any>route)._loadedConfig = r;
196196
return r.routes;
197197
});

modules/@angular/router/src/common_router_providers.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
import {Location, LocationStrategy, PathLocationStrategy} from '@angular/common';
1010
import {APP_INITIALIZER, AppModuleFactoryLoader, ApplicationRef, ComponentResolver, Injector, OpaqueToken, SystemJsAppModuleLoader} from '@angular/core';
1111

12-
import {RouterConfig} from './config';
12+
import {Routes} from './config';
1313
import {Router} from './router';
14-
import {ROUTER_CONFIG} from './router_config_loader';
14+
import {ROUTER_CONFIG, ROUTES} from './router_config_loader';
1515
import {RouterOutletMap} from './router_outlet_map';
1616
import {ActivatedRoute} from './router_state';
1717
import {DefaultUrlSerializer, UrlSerializer} from './url_tree';
1818

19-
export const ROUTER_OPTIONS = new OpaqueToken('ROUTER_OPTIONS');
19+
export const ROUTER_CONFIGURATION = new OpaqueToken('ROUTER_CONFIGURATION');
2020

2121
/**
2222
* @experimental
@@ -26,7 +26,7 @@ export interface ExtraOptions { enableTracing?: boolean; }
2626
export function setupRouter(
2727
ref: ApplicationRef, resolver: ComponentResolver, urlSerializer: UrlSerializer,
2828
outletMap: RouterOutletMap, location: Location, injector: Injector,
29-
loader: AppModuleFactoryLoader, config: RouterConfig, opts: ExtraOptions) {
29+
loader: AppModuleFactoryLoader, config: Routes, opts: ExtraOptions) {
3030
if (ref.componentTypes.length == 0) {
3131
throw new Error('Bootstrap at least one component before injecting Router.');
3232
}
@@ -82,18 +82,20 @@ export function setupRouterInitializer(injector: Injector) {
8282
*
8383
* @deprecated use RouterAppModule instead
8484
*/
85-
export function provideRouter(_config: RouterConfig, _opts: ExtraOptions): any[] {
85+
export function provideRouter(routes: Routes, config: ExtraOptions): any[] {
8686
return [
87-
{provide: ROUTER_CONFIG, useValue: _config}, {provide: ROUTER_OPTIONS, useValue: _opts},
88-
Location, {provide: LocationStrategy, useClass: PathLocationStrategy},
87+
{provide: ROUTES, useExisting: ROUTER_CONFIG}, {provide: ROUTER_CONFIG, useValue: routes},
88+
89+
{provide: ROUTER_CONFIGURATION, useValue: config}, Location,
90+
{provide: LocationStrategy, useClass: PathLocationStrategy},
8991
{provide: UrlSerializer, useClass: DefaultUrlSerializer},
9092

9193
{
9294
provide: Router,
9395
useFactory: setupRouter,
9496
deps: [
9597
ApplicationRef, ComponentResolver, UrlSerializer, RouterOutletMap, Location, Injector,
96-
AppModuleFactoryLoader, ROUTER_CONFIG, ROUTER_OPTIONS
98+
AppModuleFactoryLoader, ROUTES, ROUTER_CONFIGURATION
9799
]
98100
},
99101

@@ -122,8 +124,8 @@ export function provideRouter(_config: RouterConfig, _opts: ExtraOptions): any[]
122124
*
123125
* @experimental
124126
*/
125-
export function provideRoutes(config: RouterConfig): any {
126-
return {provide: ROUTER_CONFIG, useValue: config};
127+
export function provideRoutes(routes: Routes): any {
128+
return {provide: ROUTES, useValue: routes};
127129
}
128130

129131
/**
@@ -142,6 +144,6 @@ export function provideRoutes(config: RouterConfig): any {
142144
*
143145
* @experimental
144146
*/
145-
export function provideRouterConfig(options: ExtraOptions): any {
146-
return {provide: ROUTER_OPTIONS, useValue: options};
147+
export function provideRouterConfig(config: ExtraOptions): any {
148+
return {provide: ROUTER_CONFIGURATION, useValue: config};
147149
}

0 commit comments

Comments
 (0)