Skip to content

Commit bf91a8e

Browse files
committed
fix: Minor fixes
- Server was crashing when it encountered an expired message, now it doesn't. - Some try catches got more elaborated
1 parent cb71213 commit bf91a8e

1 file changed

Lines changed: 16 additions & 8 deletions

File tree

server/httpserver/server.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from LoginError import *
1010
from NoMessagesError import *
1111
import simplejson, json
12-
import ExpiredMessageError
12+
from ExpiredMessageError import ExpiredMessageError
1313
import traceback
1414

1515
PORT=31000
@@ -185,6 +185,7 @@ def get(self):
185185

186186
class ListMessagesHandler(tornado.web.RequestHandler):
187187
def get(self):
188+
try:
188189
try:
189190

190191
u=getUserFromToken(self.get_argument("token"))
@@ -200,8 +201,12 @@ def get(self):
200201
try:
201202
messages=[]
202203
for m in l.getMessages().values():
203-
if m.getAuthor() == u:
204-
messages+=[m.getJson(),]
204+
try:
205+
if m.getAuthor() == u:
206+
207+
messages+=[m.getJson(),]
208+
except ExpiredMessageError:
209+
continue;
205210
finalJson['messages']=messages
206211
except NoMessagesError:
207212
continue;
@@ -217,7 +222,10 @@ def get(self):
217222
if l.getName()==locationName:
218223
messages=[]
219224
for m in l.getMessages().values():
220-
messages+=[m.getJson(),]
225+
try:
226+
messages+=[m.getJson(),]
227+
except ExpiredMessageError:
228+
continue;
221229
finalJson['messages']=messages
222230
break
223231
self.write(json.dumps(finalJson ,indent=4,separators=(',', ': ')))
@@ -227,10 +235,10 @@ def get(self):
227235
except NoMessagesError:
228236
self.write(json.dumps({'type': 'listMessages','response': 'failure','reason':'no_messages_found'}\
229237
,indent=4,separators=(',', ': ')))
230-
except :
231-
traceback.print_exc()
232-
self.write(json.dumps({'type': 'listMessages','response': 'failure'}\
233-
,indent=4,separators=(',', ': ')))
238+
except :
239+
traceback.print_exc()
240+
self.write(json.dumps({'type': 'listMessages','response': 'failure'}\
241+
,indent=4,separators=(',', ': ')))
234242

235243

236244
##################################################

0 commit comments

Comments
 (0)