Feature Request: Support LCD colors on the X-Touch One

[avish]

The X-Touch one features a single LCD screen that behaves similarly to those of the X-Touch and X-Touch Extender. Specifically, it also supports setting the background color. The SysEx message that controls the colors is pretty similar to that of the X-Touch or X-Touch XT, except it uses 0x41 as the device ID instead of 0x14 or 0x15, at least according to the MIDI Implementation reference.

Seems like this should be an easy addition to the feedback processor types.
Something like (untested):

- else if ((widgetType == "FB_XTouchDisplayUpper" || widgetType == "FB_XTouchDisplayLower" || widgetType == "FB_XTouchXTDisplayUpper" || widgetType == "FB_XTouchXTDisplayLower") && size == 2)
+ else if (
+     (widgetType == "FB_XTouchDisplayUpper" || widgetType == "FB_XTouchDisplayLower" || 
+       widgetType == "FB_XTouchXTDisplayUpper" || widgetType == "FB_XTouchXTDisplayLower" || 
+       widgetType == "FB_XTouchOneDisplayUpper" || widgetType == "FB_XTouchOneDisplayLower"
+     ) && size == 2)
          {
              if (widgetType == "FB_XTouchDisplayUpper")
                  widget->GetFeedbackProcessors().push_back(make_unique<XTouchDisplay_Midi_FeedbackProcessor>(csi_, this, widget, 0, 0x14, 0x12, atoi(tokenLines[i][1].c_str())));
              else if (widgetType == "FB_XTouchDisplayLower")
                  widget->GetFeedbackProcessors().push_back(make_unique<XTouchDisplay_Midi_FeedbackProcessor>(csi_, this, widget, 1, 0x14, 0x12, atoi(tokenLines[i][1].c_str())));
              else if (widgetType == "FB_XTouchXTDisplayUpper")
                  widget->GetFeedbackProcessors().push_back(make_unique<XTouchDisplay_Midi_FeedbackProcessor>(csi_, this, widget, 0, 0x15, 0x12, atoi(tokenLines[i][1].c_str())));
              else if (widgetType == "FB_XTouchXTDisplayLower")
                  widget->GetFeedbackProcessors().push_back(make_unique<XTouchDisplay_Midi_FeedbackProcessor>(csi_, this, widget, 1, 0x15, 0x12, atoi(tokenLines[i][1].c_str())));
+             else if (widgetType == "FB_XTouchOneDisplayUpper")
+                 widget->GetFeedbackProcessors().push_back(make_unique<XTouchDisplay_Midi_FeedbackProcessor>(csi_, this, widget, 0, 0x41, 0x12, atoi(tokenLines[i][1].c_str())));
+             else if (widgetType == "FB_XTouchOneDisplayLower")
+                 widget->GetFeedbackProcessors().push_back(make_unique<XTouchDisplay_Midi_FeedbackProcessor>(csi_, this, widget, 1, 0x41, 0x12, atoi(tokenLines[i][1].c_str())));
  
              
              AddTrackColorFeedbackProcessor(widget->GetFeedbackProcessors().back().get());
          }

[rwallingford]

Avish, do you feel comfortable in modifying the source and testing on your end?

I just ordered one of these puppies.
Should be 1 week or less before it arrives.
I'll get to modifying the source as soon as it arrives.

Cheers,
Roy
(CSI Lead Dev)

[avish]

Thanks for the quick response Roy!

I could try testing locally, but I'm not sure how to build CSI on Windows. I have Ubuntu/WSL here but I'll still need to produce a Windows DLL which I'm not sure how to do. It's been a while since I built anything in C/C++. Is there a quick build guide somewhere?

Alternatively, if there's an easier way of just testing the SysEx I could try that maybe? I tried sending modified SysEx messages with Midi-OX but that fails for some unrelated reason.

Regardless, I'm excited about you getting an X-Touch One, if that means it gets more CSI love :)

[rwallingford]

Hi Avish,

Do you have a Windows machine?
If so I could set up a Zoom session where I can walk you through obtaining and installing Visual Studio 2022.
Once that's done I can walk you through getting the latest "CSI exp build" source code and build a windows DLL.
Once that's done done you could try out your proposed changes.
Always happy to have new devs :)
What do you think?

Cheers,
Roy
(CSI Lead Dev)

[avish]

Surprisingly, I managed to pull the CSIInstall source and build it using MSBuild from a VS2022 Dev Tools Command Prompt which apparently I had installed from a long gone era when I was still coding on this machine ^_^. This produced a win64/debug DLL which I think is working, because when I place it in my UserPlugins folder it pops up warning windows, which the official build doesn't do :)

Should I have used the experimental source tree instead?

Anyway -- I have applied my proposed changes and can report that using device ID 0x41 does not work, and additionally breaks support for setting the LCD text. Actually, the fact that the LCD text is working on the X-Touch One using FB_XTouchDisplayUpper or even FB_MCUDisplayUpper means that the device ID for both (0x14) is also used for the X-Touch One when in MCU mode, so I'm not sure why the colors don't work OOTB just as well. I'll keep experimenting for now. Let me know if I'm doing something completely wrong :)

[rwallingford]

Yes please use the exp source tree.

Could you also elaborate on what the warning window is showing you.

[avish]

The warning window shows:

[ERROR] FAILED to GetAction 'MoveEditCusror'
[ERROR] FAILED to GetAction 'MoveEditCusror'

This is probably due to my Home.zon containing:

    Decrease+JogWheel                MoveEditCursor Bar          
    Increase+JogWheel                MoveEditCustor Bar                                                 
    Marker+Decrease+JogWheel         MoveEditCursor Marker       
    Marker+Increase+JogWheel         MoveEditCusror Marker       

But these work despite the errors. At any rate it seems unrelated to the changes I'm trying to make.

[rwallingford]

This implies that "MoveEditCursor" is an action that does not exist in your current DLL build.
However it is an action supported in the latest EXP source build.
I suggest you build with the latest EXP source tree.
I am available for the next 7 hours this evening if you would like to have a Zoom session and get you up and running with the EXP build.

[avish]

I appreciate the offer, but I can't join a Zoom this evening as it is currently 5AM where I am (UTC+2) and I'm heading to sleep :)
I might pick this up later tomorrow or some other day.

Meanwhile I found that the X-Touch One does respond to color sysex messages just like the X-Touch, that is, using regular MCU protocol. But this only works if the message contains exactly 8 color values, and since the XTOne has number of channels set to 1, the constructed message contains a single color value and is ignored. Setting channel count to 8 in the surface settings makes it respond to color changes, but I suspect it messes with some other functionality.

I did manage to change the code to make it always send 8 color values even when the channel count is less than 8. This causes it to correctly update to the selected track color when moving between tracks using the surface's Channel Next/Prev or Bank Next/Prev buttons, but it does not update correctly when changing tracks by selecting them in Reaper. As far as I can tell this has to do with the way scroll link and paging/banking is implemented, and I couldn't figure it out further tonight. Leaving this here if you want to pick up from there, or to remind future me if I pick it up at a later time.

[rwallingford]

Ok, Maybe we should wait until I get my XTouch-1 and get the color working correctly with CSI.

[avish]

Sure, there's no urgency and it'll be way easier to figure it out once you have a unit to play with.

In general I think the X-Touch One, at least in MC mode, sort of believes it's an 8-fader MC-like controller, which somehow only displays the leftmost fader (or the master fader when its Master button is on). For example, in the default mapping it only allows you to move between tracks 1-8 using the Next/Prev Channel buttons and to get to track 9 you have to press Next Bank explicitly. CSI is pretty much the only controller script that avoids this problem, I believe due to how you've implemented scroll linking, but the same issue is what's causing trouble with getting the scribble strip colors right.

Either way, let me know if I can help in any way. I'd love to see this issue resolved and to support CSI in general.

[rwallingford]

Can you provide me a zip of your CSI folder?
I will need that to emulate/simulate your issue.

I am just being proactive so that when I receive my XT-1, I will be able to immediately start looking at these issues.

[avish]

Sure. You can get it here. It has a few customizations for my X-Touch One in Home.zon and LastTouchedFXParameter.zon but is otherwise the same as the one from CSIInstall.

[rwallingford]

Thanks Avish. I just downloaded it.
Now just waiting for my XT-1 to arrive :)

[rwallingford]

My XT-1 arrived at my local Long & McQuade store.
Picking it up later today.
Will start the code changes either Sunday evening or Monday :)