Skip to content

[contracts/security] Resolve explicit Slither audit findings for BaseBridgeLockbox #140

@FlowmemoryAI

Description

@FlowmemoryAI

PR #132 merged the accepted default-vs-audit policy path, so default product and L1 E2E now pass on main while explicit Slither audit still reports known findings.

Current evidence from isolated origin/main checkout at merge commit 14f378b:

npm run flowchain:product-e2e
npm run flowchain:l1-e2e
node infra/scripts/check-unsafe-claims.mjs
git diff --check

All passed. Explicit audit remains failing:

npm run contracts:hardening:slither

Observed findings after 84 passing Foundry tests:

  • missing-zero-check for BaseBridgeLockbox.releaseNative(...).recipient
  • low-level-calls for the native release call in BaseBridgeLockbox.releaseNative

Scope:

  • Decide whether these findings require a contract change, a Slither suppression with rationale, or a documented audit-only accepted risk.
  • Add/adjust tests or docs appropriate to the chosen path.
  • Do not use this issue to claim production bridge, real-funds bridge, or formal audit readiness.

Acceptance evidence:

  • Exact command output for npm run contracts:hardening:slither, or a documented accepted-risk/suppression path reviewed by contracts/security.
  • npm run flowchain:product-e2e
  • npm run flowchain:l1-e2e
  • node infra/scripts/check-unsafe-claims.mjs
  • git diff --check

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/contractsProtocol contracts workpriority/p1Important next prioritytype/securitySecurity process, review, threat, or audit-related work

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions