Is this necessary to send the same hex twice for packaged hex item casting

[YukkuriC]

HexMod/Common/src/main/java/at/petrak/hexcasting/api/casting/eval/env/PackagedItemCastEnv.java

Line 28 in 532fe9a

var packet = new MsgNewSpiralPatternsS2C(

and

HexMod/Common/src/main/java/at/petrak/hexcasting/common/items/magic/ItemPackagedHex.java

Line 138 in 532fe9a

var packet = new MsgNewSpiralPatternsS2C(sPlayer.getUUID(), patterns, 140);

considering there's cooldown and removing-dupe logic client-side, this could be a waste

[object-Object]

Hmm, these do have somewhat different behaviour. The logic in PackagedItemCastEnv sends one packet for every pattern executed (!), including inside of meta-evals; while the logic in ItemPackagedHex just sends one packet that only includes the patterns that are actually in the item.

I'm not sure which of these is the intended behaviour. The git blame doesn't help - both were added in the same commit, apparently. Sending a single packet is probably better for performance.

Based on StaffCastEnv, I think the intent is probably for all patterns, including from meta-evals, to show up. However, the implementation there seems a lot better for performance.

I think ideally we should remove the code in ItemPackagedHex, and either copy the StaffCastEnv logic into PackagedItemCastEnv or (preferably) refactor it into a shared helper or superclass.