Skip to content

Commit e1a6ffa

Browse files
committed
ci: fix failing tests
1 parent 259e5a0 commit e1a6ffa

4 files changed

Lines changed: 25 additions & 24 deletions

File tree

.github/workflows/code-quality.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
uses: actions/setup-java@v4
1717
with:
1818
distribution: 'temurin'
19-
java-version: '25'
19+
java-version: '21'
2020
- name: Run Checkstyle
2121
run: mvn --batch-mode checkstyle:check
2222
- name: Install reviewdog
@@ -39,7 +39,7 @@ jobs:
3939
uses: actions/setup-java@v4
4040
with:
4141
distribution: 'temurin'
42-
java-version: '25'
42+
java-version: '21'
4343
- name: Build with coverage
4444
run: mvn --batch-mode clean verify
4545
- name: Upload JaCoCo coverage report

.github/workflows/unit-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
runs-on: ubuntu-latest
1212
strategy:
1313
matrix:
14-
java-version: [ '25' ]
14+
java-version: [ '21' ]
1515
steps:
1616
- name: Checkout code
1717
uses: actions/checkout@v4
@@ -37,7 +37,7 @@ jobs:
3737
runs-on: ubuntu-latest
3838
strategy:
3939
matrix:
40-
java-version: [ '25' ]
40+
java-version: [ '21' ]
4141
steps:
4242
- name: Checkout code
4343
uses: actions/checkout@v4

pom.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
<url>https://github.com/EzFramework/JavaQueryBuilder</url>
1414

1515
<properties>
16-
<maven.compiler.source>25</maven.compiler.source>
17-
<maven.compiler.target>25</maven.compiler.target>
16+
<maven.compiler.source>21</maven.compiler.source>
17+
<maven.compiler.target>21</maven.compiler.target>
1818
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1919
</properties>
2020

@@ -40,8 +40,8 @@
4040
<artifactId>maven-compiler-plugin</artifactId>
4141
<version>3.10.1</version>
4242
<configuration>
43-
<source>25</source>
44-
<target>25</target>
43+
<source>21</source>
44+
<target>21</target>
4545
</configuration>
4646
</plugin>
4747
<plugin>

src/test/java/feature/query/QueryBuilderFeatureTest.java

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,23 @@ public class QueryBuilderFeatureTest {
1919
@DisplayName("Builds a complex SELECT with multiple conditions and dialect")
2020
void buildsComplexSelectWithDialect() {
2121
SqlResult result = new QueryBuilder()
22-
.select("id", "name", "email")
23-
.from("users")
24-
.whereEquals("status", "active")
25-
.whereLike("email", "@example.com")
26-
.whereGreaterThan("score", 100)
27-
.orderBy("created_at", false)
28-
.limit(5)
29-
.offset(10)
30-
.buildSql("users", SqlDialect.MYSQL);
31-
assertTrue(result.getSql().contains("SELECT id, name, email FROM `users`"));
32-
assertTrue(result.getSql().contains("status = ?"));
33-
assertTrue(result.getSql().contains("email LIKE ?"));
34-
assertTrue(result.getSql().contains("score > ?"));
35-
assertTrue(result.getSql().contains("ORDER BY created_at DESC"));
36-
assertTrue(result.getSql().contains("LIMIT 5"));
37-
assertTrue(result.getSql().contains("OFFSET 10"));
22+
.select("id", "name", "email")
23+
.from("users")
24+
.whereEquals("status", "active")
25+
.whereLike("email", "@example.com")
26+
.whereGreaterThan("score", 100)
27+
.orderBy("created_at", false)
28+
.limit(5)
29+
.offset(10)
30+
.buildSql("users", SqlDialect.MYSQL);
31+
String sql = result.getSql();
32+
assertTrue(sql.contains("SELECT `id`, `name`, `email` FROM `users`"), sql);
33+
assertTrue(sql.contains("`status` = ?"), sql);
34+
assertTrue(sql.contains("`email` LIKE ?"), sql);
35+
assertTrue(sql.contains("`score` > ?"), sql);
36+
assertTrue(sql.contains("ORDER BY `created_at` DESC"), sql);
37+
assertTrue(sql.contains("LIMIT 5"), sql);
38+
assertTrue(sql.contains("OFFSET 10"), sql);
3839
assertEquals(List.of("active", "%@example.com%", 100), result.getParameters());
3940
}
4041

0 commit comments

Comments
 (0)