From 9d40b41a5e2c097be0279725b9e1a6ea58bbf655 Mon Sep 17 00:00:00 2001 From: Your Name Date: Wed, 1 Apr 2026 09:58:18 -0500 Subject: [PATCH 1/5] JCF: test out Andrew's work on differential linting by intentionally writing some bad code --- .github/workflows/dunedaq-develop-cpp-ci.yml | 2 +- include/cmdlib/CommandFacility.hpp | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dunedaq-develop-cpp-ci.yml b/.github/workflows/dunedaq-develop-cpp-ci.yml index 8a52577..eac49b3 100644 --- a/.github/workflows/dunedaq-develop-cpp-ci.yml +++ b/.github/workflows/dunedaq-develop-cpp-ci.yml @@ -25,4 +25,4 @@ on: jobs: build_develop_dispatch: name: Build against the development release - uses: DUNE-DAQ/.github/.github/workflows/dunedaq-develop-cpp-ci.yml@develop \ No newline at end of file + uses: DUNE-DAQ/.github/.github/workflows/dunedaq-develop-cpp-ci.yml@amogan/single_package_linting \ No newline at end of file diff --git a/include/cmdlib/CommandFacility.hpp b/include/cmdlib/CommandFacility.hpp index 28fb443..825ced2 100644 --- a/include/cmdlib/CommandFacility.hpp +++ b/include/cmdlib/CommandFacility.hpp @@ -8,6 +8,8 @@ #ifndef CMDLIB_INCLUDE_CMDLIB_COMMANDFACILITY_HPP_ #define CMDLIB_INCLUDE_CMDLIB_COMMANDFACILITY_HPP_ +#include + #include "cmdlib/cmd/Nljs.hpp" #include "CommandedObject.hpp" #include "Issues.hpp" @@ -49,7 +51,11 @@ namespace dunedaq::cmdlib { class CommandFacility { public: - explicit CommandFacility(std::string /*uri*/) {} + explicit CommandFacility(std::string /*uri*/) { + /* These next two lines are designed to upset our linter */ + uint8_t* blob_of_raw_memory = new uint8_t[1000]; + std::cout << "The blob of raw memory starts at " << (void*)blob_of_raw_memory; + } virtual ~CommandFacility(); CommandFacility(const CommandFacility&) = delete; ///< CommandFacility is not copy-constructible From 0f4e178b100753c4a1718da88012a5142fc5f945 Mon Sep 17 00:00:00 2001 From: Your Name Date: Wed, 1 Apr 2026 12:52:01 -0500 Subject: [PATCH 2/5] JCF: use Andrew's additional caller_event_name variable for the test --- .github/workflows/dunedaq-develop-cpp-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/dunedaq-develop-cpp-ci.yml b/.github/workflows/dunedaq-develop-cpp-ci.yml index eac49b3..3ee181e 100644 --- a/.github/workflows/dunedaq-develop-cpp-ci.yml +++ b/.github/workflows/dunedaq-develop-cpp-ci.yml @@ -1,7 +1,5 @@ name: build-develop -# Controls when the action will run. Workflow runs when manually triggered using the UI -# or API. on: push: branches: @@ -25,4 +23,6 @@ on: jobs: build_develop_dispatch: name: Build against the development release - uses: DUNE-DAQ/.github/.github/workflows/dunedaq-develop-cpp-ci.yml@amogan/single_package_linting \ No newline at end of file + uses: DUNE-DAQ/.github/.github/workflows/dunedaq-develop-cpp-ci.yml@amogan/single_package_linting + with: + caller_event_name: ${{ github.event_name }} \ No newline at end of file From 72867c2c51c008fd1bfea9baed3a35e4149cc514 Mon Sep 17 00:00:00 2001 From: Your Name Date: Thu, 2 Apr 2026 14:15:39 -0500 Subject: [PATCH 3/5] JCF: manually sync dunedaq-develop-cpp-ci.yml with what's in the .github repo to reflect Andrew's changes --- .github/workflows/dunedaq-develop-cpp-ci.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/dunedaq-develop-cpp-ci.yml b/.github/workflows/dunedaq-develop-cpp-ci.yml index 3ee181e..067fb7f 100644 --- a/.github/workflows/dunedaq-develop-cpp-ci.yml +++ b/.github/workflows/dunedaq-develop-cpp-ci.yml @@ -1,4 +1,4 @@ -name: build-develop +name: Single-Package CI Build and Linting on: push: @@ -19,10 +19,15 @@ on: - cron: "0 9 * * *" workflow_dispatch: + inputs: + caller_event_name: + type: string + default: 'schedule' + description: "Enter 'pull_request' (without quotes) to compare linting results to previous linting results." jobs: build_develop_dispatch: name: Build against the development release - uses: DUNE-DAQ/.github/.github/workflows/dunedaq-develop-cpp-ci.yml@amogan/single_package_linting + uses: DUNE-DAQ/.github/.github/workflows/dunedaq-develop-cpp-ci.yml@develop with: - caller_event_name: ${{ github.event_name }} \ No newline at end of file + caller_event_name: ${{ github.event.inputs.caller_event_name || github.event_name }} \ No newline at end of file From a8131ac448dc8de38b60302f2be9be5cc3eba0fd Mon Sep 17 00:00:00 2001 From: Your Name Date: Thu, 2 Apr 2026 15:23:57 -0500 Subject: [PATCH 4/5] JCF: a commit for its own sake --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4eb1fb3..6937c95 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,3 +1,5 @@ +# This line you're reading is a commit for its own sake + cmake_minimum_required(VERSION 3.12) project(cmdlib VERSION 1.3.0) From 01902e55053d62362d08aa8cc0bcee5f085164ed Mon Sep 17 00:00:00 2001 From: Your Name Date: Thu, 2 Apr 2026 15:32:37 -0500 Subject: [PATCH 5/5] JCF: add intentionally noncompliant code --- include/cmdlib/CommandFacility.hpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/cmdlib/CommandFacility.hpp b/include/cmdlib/CommandFacility.hpp index 825ced2..e3be81c 100644 --- a/include/cmdlib/CommandFacility.hpp +++ b/include/cmdlib/CommandFacility.hpp @@ -8,6 +8,8 @@ #ifndef CMDLIB_INCLUDE_CMDLIB_COMMANDFACILITY_HPP_ #define CMDLIB_INCLUDE_CMDLIB_COMMANDFACILITY_HPP_ +#include + #include #include "cmdlib/cmd/Nljs.hpp" @@ -55,6 +57,9 @@ class CommandFacility /* These next two lines are designed to upset our linter */ uint8_t* blob_of_raw_memory = new uint8_t[1000]; std::cout << "The blob of raw memory starts at " << (void*)blob_of_raw_memory; + + uint8_t* a_new_blob_of_raw_memory = new uint8_t[1000]; + std::cout << "The new blob of raw memory starts at " << (void*)blob_of_raw_memory; } virtual ~CommandFacility(); CommandFacility(const CommandFacility&) =