chore(env): drop dead dialect + define fields from env.js exports#261
Merged
Conversation
`app/config/env.js` exported two fields neither consumer reads:
- `dialect: 'postgres'` — `db.config.js` (line 28) and
`sequelize-cli.config.js` (line 20) both hardcode `'postgres'`
inline; neither references `env.dialect`.
- `define: { timestamps: false }` — both consumers override with
`define: { schema: 'dbo', timestamps: true }`, so the `false`
in env.js was both dead AND misleading (a reader scanning env.js
could conclude the runtime has timestamps disabled when in fact
PR #148 flipped both consumers to `true`).
Verified via grep — nothing in app/, server.js, or tests/ touches
`env.dialect` or `env.define`. Drop both. No behavior change;
just stops env.js from misrepresenting the runtime.
688 tests still pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop two dead/misleading fields from
app/config/env.js:dialect: 'postgres'— neither consumer reads it.db.config.jsandsequelize-cli.config.jsboth hardcode'postgres'inline.define: { timestamps: false }— both consumers override withdefine: { schema: 'dbo', timestamps: true }. Thefalsewas both dead AND misleading: a reader scanning env.js could conclude the runtime has timestamps disabled when in fact PR chore(db): flip global timestamps default from false to true to match every model's explicit override #148 flipped them on everywhere.Verification
grep -rn "env\.dialect\|env\.define" app/ server.js tests/returns nothing.npm run lint && npm test— 688 passing, no regressionsTest plan
Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/