Skip to content

docs(idempotency): correct misleading Awaited prune comment #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 19, 2026
Merged

docs(idempotency): correct misleading Awaited prune comment #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/middleware/idempotency.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,9 @@ async function idempotency(req, res, next) {
const scope = buildScope(req);
const bodyHash = hashBody(req.body);

// Best-effort prune. Awaited so we don't pile up overlapping
// DELETEs under load; cheap because the index covers it.
// Best-effort prune. Fire-and-forget so the request path never
// waits on DELETE; errors are swallowed via the .catch(). Cheap
// because the index on ikExpiresAt covers it.
pruneExpired(getDb().sequelize).catch(() => {});

let existing;
Expand Down