Skip to content

chore(auth): drop dead attachOk guard in resolveAuth #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 19, 2026
Merged

chore(auth): drop dead attachOk guard in resolveAuth #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/middleware/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,11 +326,9 @@ function requireAuth(req, res, next) {
* out of the strict 403 (like /v1/whoami).
*/
async function resolveAuth(req, res, next) {
let attachOk = false;
await new Promise((resolve) => {
attachAuth(req, res, () => { attachOk = true; resolve(); });
attachAuth(req, res, () => resolve());
});
if (!attachOk) return; // attachAuth already sent a 500
return requireAuth(req, res, next);
}

Expand Down