chore(auth): drop dead attachOk guard in resolveAuth#256
Merged
Conversation
Cleanup follow-up to #162, which removed the outer try/catch in attachAuth. Since attachAuth no longer has any 500-emitting path (its internal callees swallow infrastructure errors into sentinels and always invoke next()), the `attachOk` boolean was guaranteed true after the awaited Promise resolved. The dead `if (!attachOk) return;` line and its stale "attachAuth already sent a 500" comment misled readers into thinking resolveAuth still had a divergent error path. Drop both. Behavior unchanged. All 688 tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup follow-up to #162, which removed the outer try/catch around
isMaster+getCompanyIdinattachAuth.Since that change,
attachAuthno longer has any 500-emitting path — its callees swallow DB-infrastructure errors into sentinels (false/-1) and always invokenext(). TheattachOkboolean inresolveAuthwas therefore guaranteed true after the awaited Promise resolved, and the comment "attachAuth already sent a 500" misled readers into thinking there was still a divergent error path.Drop the dead conditional and its stale comment. Behavior unchanged.
Test plan
npm run lint && npm test— 688 passing, no regressionsProudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/