docs(openapi): declare Idempotency-Replay on POST /v1/inventoryitem 201#255
Merged
CryptoJones merged 1 commit intoMay 19, 2026
Conversation
Continuation of the single-create POST sweep (tracking #245). The Idempotency-Key middleware already applies to /v1/inventoryitem POSTs, but the response-header declaration was missing from the 201 — so SDK generators couldn't surface the replay flag for non-bulk inventoryitem creates. Adds `headers: idempotencyReplayResponseHeader` to the 201 response, matching the pattern previously applied to customer/timeentry/worker/billingtype POSTs. No behavior change — pure spec metadata. All 688 tests still pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CryptoJones
deleted the
docs/openapi-inventoryitem-post-idempotency-replay-header
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #245 — single-create POST OpenAPI Idempotency-Replay sweep.
Summary
Idempotency-Replayresponse-header declaration to the 201 response onPOST /v1/inventoryitemWhy
The Idempotency-Key middleware applies to every
/v1/*POST, but until now only the bulk endpoints (and four single-create endpoints) declared theIdempotency-Replayresponse header on their 201. SDK generators (openapi-typescript, etc.) couldn't see the replay flag for inventoryitem creates without this declaration.Test plan
npm run lint && npm testlocally — 688 passing, no regressionsProudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/