Skip to content

chore(server): tighten SHUTDOWN_TIMEOUT_MS parsing to non-negative integers only #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 19, 2026
Merged

chore(server): tighten SHUTDOWN_TIMEOUT_MS parsing to non-negative integers only #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,15 @@ const server = app.listen(port, host, () => {
// window), we force-exit with code 1. SIGINT (Ctrl-C in dev) follows
// the same path so dev shutdowns aren't dirty either.

const shutdownTimeoutMs = parseInt(process.env.SHUTDOWN_TIMEOUT_MS, 10) || 25_000;
// `parseInt(...) || 25_000` accepts negative integers (parseInt('-100')
// = -100 is truthy, so it'd be used as the timeout — setTimeout(-100)
// fires immediately, force-exiting before the drain has a chance to
// run). Guard with the same Number.isFinite + >= 0 check used for
// PORT (#124) so only NaN and negatives fall back to the default.
const shutdownTimeoutRaw = parseInt(process.env.SHUTDOWN_TIMEOUT_MS, 10);
const shutdownTimeoutMs = Number.isFinite(shutdownTimeoutRaw) && shutdownTimeoutRaw >= 0
? shutdownTimeoutRaw
: 25_000;
let shuttingDown = false;

async function shutdown(signal) {
Expand Down