Skip to content

docs(_bulk-helpers): customer/bulk now uses the factory — drop stale callout #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 19, 2026
Merged

docs(_bulk-helpers): customer/bulk now uses the factory — drop stale callout #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions app/controllers/_bulk-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@

/**
* Shared factory for bulk-create controllers on entities that scope
* directly to a single company via a *CompId column. Customer's
* bulkCreate predates this helper and has the same shape baked in;
* we don't migrate it here to keep the diff focused on the new
* endpoints (P3-H), but a follow-up should consolidate them.
* directly to a single company via a *CompId column.
*
* What this factory replaces: 5 near-identical controllers
* (worker/billingtype/inventoryitem/inventorytransaction/
* What this factory replaces: 6 near-identical controllers
* (customer/worker/billingtype/inventoryitem/inventorytransaction/
* purchaseordervendor) each repeating the same auth-scope-loop-
* transaction-bulkCreate-handle-error scaffold.
* transaction-bulkCreate-handle-error scaffold. Customer was the
* original hand-rolled implementation; the factory replaced 5
* later-added clones in P3-H and Customer was migrated to use the
* factory in a follow-up.
*
* What varies between entities — passed as config:
* - Model the sequelize model (db.Worker etc.)
Expand Down