docs(_bulk-helpers): customer/bulk now uses the factory — drop stale callout#250
Merged
Merged
Conversation
…"predates" callout
The header JSDoc on \`_bulk-helpers.js\` said:
"Customer's bulkCreate predates this helper and has the same shape
baked in; we don't migrate it here to keep the diff focused on the
new endpoints (P3-H), but a follow-up should consolidate them."
That follow-up landed; \`customercontroller.js\` now exports
\`bulkCreate = makeBulkCreate({ ... })\` like every other bulk-direct
endpoint, and Customer is among the 6 entities the factory serves.
The "5 near-identical controllers it replaces" line was also off by
one for the same reason.
Update both lines to match reality: 6 entities use the factory,
Customer was migrated in a follow-up after the original P3-H rollout.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSDoc on
_bulk-helpers.jssaid "Customer's bulkCreate predates this helper... a follow-up should consolidate them." That follow-up landed; Customer already usesmakeBulkCreate. Update the comment to match reality (and bump "5 near-identical controllers" to 6).Test plan
npm run lintcleannpm test— 688 passed (comment-only change)Proudly Made in Nebraska. Go Big Red! 🌽 https://xkcd.com/2347/