Skip to content

chore(metrics): remove dead-code branch from route-label derivation #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptoJones merged 1 commit into from
May 19, 2026
Merged

chore(metrics): remove dead-code branch from route-label derivation #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions app/middleware/metrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,13 @@ function metricsMiddleware(req, res, next) {
res.on('finish', () => {
const elapsedSec = Number(process.hrtime.bigint() - start) / 1e9;
// After Express has matched, req.route?.path is the route
// pattern. For 404s req.route is undefined; bucket those
// into a single label so the metric doesn't grow per
// distinct mistyped URL.
const route = (req.route && req.route.path)
|| (req.baseUrl && req.route && req.baseUrl + req.route.path)
|| '<unknown>';
// pattern (e.g. `/v1/customer/:id`). For 404s req.route is
// undefined; bucket those into a single `<unknown>` label so
// cardinality doesn't grow per distinct mistyped URL. Every
// route in this codebase is mounted at the top-level router
// with its full path, so the pattern already includes the
// /v1 prefix — there is no `req.baseUrl` to prepend.
const route = (req.route && req.route.path) || '<unknown>';
const labels = {
method: req.method,
route,
Expand Down