Merge PR #197: fix(cortex-tui): use terminal height for Page Up/Down scrolling

Author: factorydroid

cortex-tui/src/runner/event_loop.rs

@@ -2239,8 +2239,20 @@ impl EventLoop {
             // Scroll actions
             KeyAction::ScrollUp => self.app_state.scroll_chat(-1),
             KeyAction::ScrollDown => self.app_state.scroll_chat(1),
-            KeyAction::ScrollPageUp => self.app_state.scroll_chat(-10),
-            KeyAction::ScrollPageDown => self.app_state.scroll_chat(10),
+            KeyAction::ScrollPageUp => {
+                // Use terminal height - 1 for standard page scroll (provides context overlap)
+                let page_size = (self.app_state.terminal_size.1 as i32)
+                    .saturating_sub(1)
+                    .max(1);
+                self.app_state.scroll_chat(-page_size);
+            }
+            KeyAction::ScrollPageDown => {
+                // Use terminal height - 1 for standard page scroll (provides context overlap)
+                let page_size = (self.app_state.terminal_size.1 as i32)
+                    .saturating_sub(1)
+                    .max(1);
+                self.app_state.scroll_chat(page_size);
+            }
             KeyAction::ScrollToTop => self.app_state.scroll_chat_to_top(),
             KeyAction::ScrollToBottom => self.app_state.scroll_chat_to_bottom(),
 

cortex-tui/src/runner/handlers.rs

@@ -115,8 +115,16 @@ impl<'a> ActionHandler<'a> {
             // Scrolling
             KeyAction::ScrollUp => self.handle_scroll(-1),
             KeyAction::ScrollDown => self.handle_scroll(1),
-            KeyAction::ScrollPageUp => self.handle_scroll(-10),
-            KeyAction::ScrollPageDown => self.handle_scroll(10),
+            KeyAction::ScrollPageUp => {
+                // Use terminal height - 1 for standard page scroll (provides context overlap)
+                let page_size = (self.state.terminal_size.1 as i32).saturating_sub(1).max(1);
+                self.handle_scroll(-page_size)
+            }
+            KeyAction::ScrollPageDown => {
+                // Use terminal height - 1 for standard page scroll (provides context overlap)
+                let page_size = (self.state.terminal_size.1 as i32).saturating_sub(1).max(1);
+                self.handle_scroll(page_size)
+            }
             KeyAction::ScrollToTop => self.handle_scroll_to_top(),
             KeyAction::ScrollToBottom => self.handle_scroll_to_bottom(),
 
@@ -1072,9 +1080,12 @@ mod tests {
         let mut stream = create_test_stream();
         state.set_focus(FocusTarget::Chat);
 
+        // Default terminal size is (80, 24), so page size = 24 - 1 = 23
+        let expected_page_size = (state.terminal_size.1 as usize).saturating_sub(1).max(1);
+
         let result = run_action(&mut state, &mut stream, KeyAction::ScrollPageDown).await;
         assert!(result.is_ok());
         assert!(result.unwrap());
-        assert_eq!(state.chat_scroll, 10);
+        assert_eq!(state.chat_scroll, expected_page_size);
     }
 }