[CDX-384]: improved itemIds validation and test coverage

Author: niizom

.gitignore

@@ -7,6 +7,9 @@ test
 # OS X specific files
 .DS_Store
 
+# Editor specific files
+.idea
+
 # Logs
 logs
 *.log

spec/src/modules/recommendations.js

@@ -124,6 +124,7 @@ describe(`ConstructorIO - Recommendations${bundledDescriptionSuffix}`, () => {
         expect(requestedUrlParams).to.have.property('c').to.equal(clientVersion);
         expect(requestedUrlParams).to.have.property('item_id').to.equal(itemId);
         expect(requestedUrlParams).to.have.property('variation_id').to.equal(variationId);
+        expect(res.request.variation_id).to.equal(variationId);
         done();
       });
     });
@@ -499,6 +500,15 @@ describe(`ConstructorIO - Recommendations${bundledDescriptionSuffix}`, () => {
       })).to.eventually.be.rejected;
     });
 
+    it('Should be rejected when variationId is provided with an empty itemIds array', () => {
+      const { recommendations } = new ConstructorIO({ apiKey: testApiKey });
+
+      return expect(recommendations.getRecommendations(podId, {
+        variationId,
+        itemIds: [],
+      })).to.eventually.be.rejected;
+    });
+
     it('Should be rejected when invalid pod id parameter is provided', () => {
       const { recommendations } = new ConstructorIO({ apiKey: testApiKey });
 

src/modules/recommendations.js

@@ -52,7 +52,7 @@ function createRecommendationsUrl(podId, parameters, options) {
     }
 
     if (variationId) {
-      if (!itemIds) {
+      if (!itemIds || (typeof itemIds === 'string' && !itemIds.trim())) {
         throw new Error('itemIds is a required parameter for variationId');
       }