refactor: remove TEST_USER_ID from production code entirely

- Remove TEST_USER_ID checks from balance-calculator.ts (billing bypass)
- Remove TEST_USER_ID checks from stripe-metering.ts (already has CI check)
- Remove TEST_USER_ID checks from agent-runs API endpoints
- Replace TEST_USER_ID with local ADMIN_RELABEL_USER_ID in admin route
- Remove TEST_USER_ID export from old-constants.ts
- Remove TEST_USER_ID from test fixtures (use inline strings instead)
- Update 18 test files to use inline test-user-id string

The hardcoded test user bypass was a hack that coupled test infrastructure
to production billing code. Tests now use inline strings and production
code relies on environment checks (CI=true) to skip billing in test envs.

Author: brandonkachen

common/src/old-constants.ts

@@ -311,7 +311,6 @@ export function supportsCacheControl(model: Model): boolean {
   return !nonCacheableModels.includes(model)
 }
 
-export const TEST_USER_ID = 'test-user-id'
 
 export function getModelFromShortName(
   modelName: string | undefined,

common/src/testing/fixtures.ts

@@ -3,7 +3,7 @@
  *
  * Import test fixtures from this module:
  * ```typescript
- * import { testLogger, createTestAgentRuntimeParams, TEST_USER_ID } from '@codebuff/common/testing/fixtures'
+ * import { testLogger, createTestAgentRuntimeParams } from '@codebuff/common/testing/fixtures'
  * ```
  */
 

common/src/testing/fixtures/billing.ts

@@ -15,17 +15,10 @@ import type { MockCreditGrant, MockUser, MockDbConfig } from '../mock-db'
 
 /**
  * Test user ID for billing tests.
- * Use this instead of importing TEST_USER_ID from old-constants.
+ * Use this shared ID in tests instead of hardcoding user IDs.
  */
 export const TEST_BILLING_USER_ID = 'test-billing-user-id'
 
-/**
- * Test user ID matching the value in old-constants.ts.
- * This is exported here for tests that need to use the same value.
- * Prefer TEST_BILLING_USER_ID for new tests.
- */
-export const TEST_USER_ID = 'test-user-id'
-
 // ============================================================================
 // Test date helpers
 // ============================================================================

common/src/testing/fixtures/index.ts

@@ -12,7 +12,6 @@ export * from './agent-runtime'
 // Re-export billing fixtures except testLogger (already exported from agent-runtime)
 export {
   TEST_BILLING_USER_ID,
-  TEST_USER_ID,
   createFutureDate,
   createPastDate,
   createMockCreditGrant,

packages/agent-runtime/src/__tests__/fast-rewrite.test.ts

@@ -1,6 +1,6 @@
 import path from 'path'
 
-import { TEST_USER_ID } from '@codebuff/common/testing/fixtures'
+
 import { createTestAgentRuntimeParams } from '@codebuff/common/testing/fixtures/agent-runtime'
 import { beforeEach, describe, expect, it } from 'bun:test'
 import { createPatch } from 'diff'
@@ -33,7 +33,7 @@ describe('rewriteWithOpenAI', () => {
       clientSessionId: 'clientSessionId',
       fingerprintId: 'fingerprintId',
       userInputId: 'userInputId',
-      userId: TEST_USER_ID,
+      userId: 'test-user-id',
       runId: 'test-run-id',
     })
 

packages/agent-runtime/src/__tests__/loop-agent-steps.test.ts

@@ -1,6 +1,6 @@
 import * as bigquery from '@codebuff/bigquery'
 import * as analytics from '@codebuff/common/analytics'
-import { TEST_USER_ID } from '@codebuff/common/testing/fixtures'
+
 import { createTestAgentRuntimeParams } from '@codebuff/common/testing/fixtures/agent-runtime'
 import { getInitialSessionState } from '@codebuff/common/types/session-state'
 import { assistantMessage, userMessage } from '@codebuff/common/util/messages'
@@ -122,7 +122,7 @@ describe('loopAgentSteps - runAgentStep vs runProgrammaticStep behavior', () =>
       spawnParams: undefined,
       fingerprintId: 'test-fingerprint',
       fileContext: mockFileContext,
-      userId: TEST_USER_ID,
+      userId: 'test-user-id',
       clientSessionId: 'test-session',
       ancestorRunIds: [],
       onResponseChunk: () => {},

packages/agent-runtime/src/__tests__/main-prompt.test.ts

@@ -1,6 +1,6 @@
 import * as bigquery from '@codebuff/bigquery'
 import * as analytics from '@codebuff/common/analytics'
-import { TEST_USER_ID } from '@codebuff/common/testing/fixtures'
+
 import { createTestAgentRuntimeParams } from '@codebuff/common/testing/fixtures/agent-runtime'
 import {
   AgentTemplateTypes,
@@ -88,7 +88,7 @@ describe('mainPrompt', () => {
       ...createTestAgentRuntimeParams(),
       repoId: undefined,
       repoUrl: undefined,
-      userId: TEST_USER_ID,
+      userId: 'test-user-id',
       clientSessionId: 'test-session',
       onResponseChunk: () => {},
       localAgentTemplates: mockLocalAgentTemplates,

packages/agent-runtime/src/__tests__/n-parameter.test.ts

@@ -1,5 +1,5 @@
 import * as analytics from '@codebuff/common/analytics'
-import { TEST_USER_ID } from '@codebuff/common/testing/fixtures'
+
 import { createTestAgentRuntimeParams } from '@codebuff/common/testing/fixtures/agent-runtime'
 import { getInitialSessionState } from '@codebuff/common/types/session-state'
 import { assistantMessage, userMessage } from '@codebuff/common/util/messages'
@@ -99,7 +99,7 @@ describe('n parameter and GENERATE_N functionality', () => {
       ancestorRunIds: [],
       repoId: undefined,
       repoUrl: undefined,
-      userId: TEST_USER_ID,
+      userId: 'test-user-id',
       userInputId: 'test-input',
       clientSessionId: 'test-session',
       fingerprintId: 'test-fingerprint',
@@ -237,7 +237,7 @@ describe('n parameter and GENERATE_N functionality', () => {
           template: mockTemplate,
           prompt: 'Test prompt',
           toolCallParams: {},
-          userId: TEST_USER_ID,
+          userId: 'test-user-id',
           userInputId: 'test-user-input',
           clientSessionId: 'test-session',
           fingerprintId: 'test-fingerprint',
@@ -277,7 +277,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test prompt',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-user-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -342,7 +342,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test prompt',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-user-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -425,7 +425,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -521,7 +521,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -586,7 +586,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -625,7 +625,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -672,7 +672,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -716,7 +716,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -779,7 +779,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',
@@ -827,7 +827,7 @@ describe('n parameter and GENERATE_N functionality', () => {
         template: mockTemplate,
         prompt: 'Test',
         toolCallParams: {},
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         userInputId: 'test-input',
         clientSessionId: 'test-session',
         fingerprintId: 'test-fingerprint',

packages/agent-runtime/src/__tests__/process-file-block.test.ts

@@ -1,4 +1,4 @@
-import { TEST_USER_ID } from '@codebuff/common/testing/fixtures'
+
 import { TEST_AGENT_RUNTIME_IMPL } from '@codebuff/common/testing/impl/agent-runtime'
 import { cleanMarkdownCodeBlock } from '@codebuff/common/util/file'
 import { beforeEach, describe, expect, it } from 'bun:test'
@@ -59,7 +59,7 @@ describe('processFileBlockModule', () => {
         clientSessionId: 'clientSessionId',
         fingerprintId: 'fingerprintId',
         userInputId: 'userInputId',
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         signal: new AbortController().signal,
       })
 
@@ -111,7 +111,7 @@ describe('processFileBlockModule', () => {
         clientSessionId: 'clientSessionId',
         fingerprintId: 'fingerprintId',
         userInputId: 'userInputId',
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         signal: new AbortController().signal,
       })
 
@@ -146,7 +146,7 @@ describe('processFileBlockModule', () => {
         clientSessionId: 'clientSessionId',
         fingerprintId: 'fingerprintId',
         userInputId: 'userInputId',
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         signal: new AbortController().signal,
       })
 
@@ -187,7 +187,7 @@ describe('processFileBlockModule', () => {
         clientSessionId: 'clientSessionId',
         fingerprintId: 'fingerprintId',
         userInputId: 'userInputId',
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         signal: new AbortController().signal,
       })
 
@@ -236,7 +236,7 @@ describe('processFileBlockModule', () => {
         clientSessionId: 'clientSessionId',
         fingerprintId: 'fingerprintId',
         userInputId: 'userInputId',
-        userId: TEST_USER_ID,
+        userId: 'test-user-id',
         signal: new AbortController().signal,
       })
 

packages/agent-runtime/src/__tests__/prompt-caching-subagents.test.ts

@@ -1,4 +1,4 @@
-import { TEST_USER_ID } from '@codebuff/common/testing/fixtures'
+
 import { TEST_AGENT_RUNTIME_IMPL } from '@codebuff/common/testing/impl/agent-runtime'
 import { getInitialSessionState } from '@codebuff/common/types/session-state'
 import { assistantMessage, userMessage } from '@codebuff/common/util/messages'
@@ -131,7 +131,7 @@ describe('Prompt Caching for Subagents with inheritParentSystemPrompt', () => {
       fingerprintId: 'test-fingerprint',
       fileContext: mockFileContext,
       localAgentTemplates: mockLocalAgentTemplates,
-      userId: TEST_USER_ID,
+      userId: 'test-user-id',
       clientSessionId: 'test-session',
       ancestorRunIds: [],
       onResponseChunk: () => {},