From 4c160fb5ad590a37134d109285c15296ef7b6f31 Mon Sep 17 00:00:00 2001 From: Elisabeth-Matulian Date: Thu, 19 Feb 2026 21:08:25 +0000 Subject: [PATCH 1/5] sprint 3 in progress --- .../implement/1-get-angle-type.js | 38 ++++++++++++++++++- .../implement/2-is-proper-fraction.js | 9 ++++- .../implement/3-get-card-value.js | 12 +++++- .../1-get-angle-type.test.js | 24 ++++++++++++ .../2-is-proper-fraction.test.js | 24 ++++++++++++ .../3-get-card-value.test.js | 19 ++++++++++ 6 files changed, 123 insertions(+), 3 deletions(-) diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js index 9e05a871e..e0361aeb3 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -15,7 +15,12 @@ // execute the code to ensure all tests pass. function getAngleType(angle) { - // TODO: Implement this function + if (angle > 0 && angle < 90) return "Acute angle"; + else if (angle === 90) return "Right angle"; + else if (90 < angle && angle < 180) return "Obtuse angle"; + else if (angle === 180) return "Straight angle"; + else if (180 < angle && angle < 360) return "Reflex angle"; + else return "Invalid angle" } // The line below allows us to load the getAngleType function into tests in other files. @@ -35,3 +40,34 @@ function assertEquals(actualOutput, targetOutput) { // Example: Identify Right Angles const right = getAngleType(90); assertEquals(right, "Right angle"); +let acute = getAngleType(1); +assertEquals(acute, "Acute angle"); +acute = getAngleType(45); +assertEquals(acute, "Acute angle"); +acute = getAngleType(89); +assertEquals(acute, "Acute angle"); +let obtuse = getAngleType(91); +assertEquals(obtuse, "Obtuse angle"); +obtuse = getAngleType(100); +assertEquals(obtuse, "Obtuse angle"); +obtuse = getAngleType(179); +assertEquals(obtuse, "Obtuse angle"); +const straight = getAngleType(180); +assertEquals(straight, "Straight angle"); +let reflex = getAngleType(181); +assertEquals(reflex, "Reflex angle"); +reflex = getAngleType(200); +assertEquals(reflex, "Reflex angle"); +reflex = getAngleType(359); +assertEquals(reflex, "Reflex angle"); +let invalid = getAngleType(-1); +assertEquals(invalid, "Invalid angle"); +invalid = getAngleType(0); +assertEquals(invalid, "Invalid angle"); +invalid = getAngleType(360); +assertEquals(invalid, "Invalid angle"); +invalid = getAngleType(361); +assertEquals(invalid, "Invalid angle"); + + + diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js index 970cb9b64..6f9cc64ea 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -11,7 +11,7 @@ // execute the code to ensure all tests pass. function isProperFraction(numerator, denominator) { - // TODO: Implement this function + return Math.abs(numerator) < Math.abs(denominator) } // The line below allows us to load the isProperFraction function into tests in other files. @@ -31,3 +31,10 @@ function assertEquals(actualOutput, targetOutput) { // Example: 1/2 is a proper fraction assertEquals(isProperFraction(1, 2), true); +assertEquals(isProperFraction(7, 1), false); +assertEquals(isProperFraction(0, 5), true); +assertEquals(isProperFraction(-1, -2), true); +assertEquals(isProperFraction(-2, -1), false); +assertEquals(isProperFraction(-2, 5), true); +assertEquals(isProperFraction(5, -2), false); +assertEquals(isProperFraction(5, 5), false); \ No newline at end of file diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js index c7559e787..72d345884 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js @@ -22,7 +22,11 @@ // execute the code to ensure all tests pass. function getCardValue(card) { - // TODO: Implement this function + const cardNum = card.slice(0, -1) + if (cardNum === "A") { return 11} + else if (["J", "Q", "K"].includes(cardNum)) { return 10} + else if (Number(cardNum) >= 2 && Number(cardNum) <= 10) {return Number(cardNum)} + else throw new Error("Invalid card"); } // The line below allows us to load the getCardValue function into tests in other files. @@ -40,6 +44,12 @@ function assertEquals(actualOutput, targetOutput) { // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards. // Examples: assertEquals(getCardValue("9♠"), 9); +assertEquals(getCardValue("A♠"), 11); +assertEquals(getCardValue("2♥"), 2); +assertEquals(getCardValue("10♥"), 10); +assertEquals(getCardValue("Q♦"), 10); +assertEquals(getCardValue("♦Q"), "Invalid card"); +assertEquals(getCardValue("11♦"), "Invalid card"); // Handling invalid cards try { diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js index d777f348d..ab1159f0d 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js +++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js @@ -14,7 +14,31 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => { }); // Case 2: Right angle +test(`should return "Right angle" when (angle = 90)`, () => { + expect(getAngleType(90)).toEqual("Right angle"); +}); // Case 3: Obtuse angles +test(`should return "Obtuse angle" when (90 < angle < 180)`, () => { + expect(getAngleType(91)).toEqual("Obtuse angle"); + expect(getAngleType(100)).toEqual("Obtuse angle"); + expect(getAngleType(179)).toEqual("Obtuse angle"); +}); // Case 4: Straight angle +test(`should return "Straight angle" when (angle = 180)`, () => { + expect(getAngleType(180)).toEqual("Straight angle"); +}); // Case 5: Reflex angles +test(`should return "Reflex angle" when (180 < angle < 360)`, () => { + expect(getAngleType(181)).toEqual("Reflex angle"); + expect(getAngleType(200)).toEqual("Reflex angle"); + expect(getAngleType(359)).toEqual("Reflex angle"); +}); // Case 6: Invalid angles +test(`should return "Invalid angle" when (360 <= angle or angle <= 0)`, () => { + expect(getAngleType(-1)).toEqual("Invalid angle"); + expect(getAngleType(0)).toEqual("Invalid angle"); + expect(getAngleType(360)).toEqual("Invalid angle"); + expect(getAngleType(361)).toEqual("Invalid angle"); +}); + + diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js index 7f087b2ba..1e8a4a1ad 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js +++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js @@ -8,3 +8,27 @@ const isProperFraction = require("../implement/2-is-proper-fraction"); test(`should return false when denominator is zero`, () => { expect(isProperFraction(1, 0)).toEqual(false); }); +test(`1/2`, () => { + expect(isProperFraction(1, 2)).toEqual(true); +}); +test(`7/1`, () => { + expect(isProperFraction(7, 1)).toEqual(false); +}); +test(`0/5`, () => { + expect(isProperFraction(0, 5)).toEqual(true); +}); +test(`-1/-2`, () => { + expect(isProperFraction(-1, -2)).toEqual(true); +}); +test(`-2/-1`, () => { + expect(isProperFraction(-2, -1)).toEqual(false); +}); +test(`-2/5`, () => { + expect(isProperFraction(-2, 5)).toEqual(true); +}); +test(`5/-2`, () => { + expect(isProperFraction(5, -2)).toEqual(false); +}); +test(`5/5`, () => { + expect(isProperFraction(5, 5)).toEqual(false); +}); diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index cf7f9dae2..0ad678ad7 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -8,6 +8,25 @@ const getCardValue = require("../implement/3-get-card-value"); test(`Should return 11 when given an ace card`, () => { expect(getCardValue("A♠")).toEqual(11); }); +test(`Should return 9 when given an 9♠`, () => { + expect(getCardValue("9♠")).toEqual(9); +}); +test(`Should return 2 when given an 2♥`, () => { + expect(getCardValue("2♥")).toEqual(2); +}); +test(`Should return 10 when given an 10♥`, () => { + expect(getCardValue("10♥")).toEqual(10); +}); +test(`Should return 10 when given an Q♦`, () => { + expect(getCardValue("Q♦")).toEqual(10); +}); +test(`Should return Error when given an ♦Q`, () => { + expect(getCardValue("♦Q")).toThrow("Invalid card"); +}); +test(`Should return Error when given an 11♦`, () => { + expect(getCardValue("11♦")).toThrow("Invalid card"); +}); + // Suggestion: Group the remaining test data into these categories: // Number Cards (2-10) From fb170d61d0f7714eba07954466178e2ce471592b Mon Sep 17 00:00:00 2001 From: Elisabeth-Matulian Date: Fri, 20 Feb 2026 11:54:53 +0000 Subject: [PATCH 2/5] card-value-tests-in-progress --- .../implement/3-get-card-value.js | 4 ++-- .../rewrite-tests-with-jest/3-get-card-value.test.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js index 72d345884..b91707840 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js @@ -48,8 +48,8 @@ assertEquals(getCardValue("A♠"), 11); assertEquals(getCardValue("2♥"), 2); assertEquals(getCardValue("10♥"), 10); assertEquals(getCardValue("Q♦"), 10); -assertEquals(getCardValue("♦Q"), "Invalid card"); -assertEquals(getCardValue("11♦"), "Invalid card"); +//assertEquals(getCardValue("♦Q"), "Invalid card"); ??? +//assertEquals(getCardValue("11♦"), "Invalid card"); ??? // Handling invalid cards try { diff --git a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js index 0ad678ad7..dc5ba40f9 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js +++ b/Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js @@ -21,10 +21,10 @@ test(`Should return 10 when given an Q♦`, () => { expect(getCardValue("Q♦")).toEqual(10); }); test(`Should return Error when given an ♦Q`, () => { - expect(getCardValue("♦Q")).toThrow("Invalid card"); + expect(function() {getCardValue("♦Q");}).toThrow("Invalid card"); }); test(`Should return Error when given an 11♦`, () => { - expect(getCardValue("11♦")).toThrow("Invalid card"); + expect(function() {getCardValue("11♦")}).toThrow("Invalid card"); }); From ca7ea043e6f03443bc3dddb60b56981b36d3f7df Mon Sep 17 00:00:00 2001 From: Elisabeth-Matulian Date: Fri, 20 Feb 2026 12:07:18 +0000 Subject: [PATCH 3/5] Commented-old-tests before-Jest-run --- .../implement/1-get-angle-type.js | 60 +++++++++---------- .../implement/2-is-proper-fraction.js | 16 ++--- .../implement/3-get-card-value.js | 10 ++-- 3 files changed, 43 insertions(+), 43 deletions(-) diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js index e0361aeb3..f2fb9c160 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -38,36 +38,36 @@ function assertEquals(actualOutput, targetOutput) { // TODO: Write tests to cover all cases, including boundary and invalid cases. // Example: Identify Right Angles -const right = getAngleType(90); -assertEquals(right, "Right angle"); -let acute = getAngleType(1); -assertEquals(acute, "Acute angle"); -acute = getAngleType(45); -assertEquals(acute, "Acute angle"); -acute = getAngleType(89); -assertEquals(acute, "Acute angle"); -let obtuse = getAngleType(91); -assertEquals(obtuse, "Obtuse angle"); -obtuse = getAngleType(100); -assertEquals(obtuse, "Obtuse angle"); -obtuse = getAngleType(179); -assertEquals(obtuse, "Obtuse angle"); -const straight = getAngleType(180); -assertEquals(straight, "Straight angle"); -let reflex = getAngleType(181); -assertEquals(reflex, "Reflex angle"); -reflex = getAngleType(200); -assertEquals(reflex, "Reflex angle"); -reflex = getAngleType(359); -assertEquals(reflex, "Reflex angle"); -let invalid = getAngleType(-1); -assertEquals(invalid, "Invalid angle"); -invalid = getAngleType(0); -assertEquals(invalid, "Invalid angle"); -invalid = getAngleType(360); -assertEquals(invalid, "Invalid angle"); -invalid = getAngleType(361); -assertEquals(invalid, "Invalid angle"); +// const right = getAngleType(90); +// assertEquals(right, "Right angle"); +// let acute = getAngleType(1); +// assertEquals(acute, "Acute angle"); +// acute = getAngleType(45); +// assertEquals(acute, "Acute angle"); +// acute = getAngleType(89); +// assertEquals(acute, "Acute angle"); +// let obtuse = getAngleType(91); +// assertEquals(obtuse, "Obtuse angle"); +// obtuse = getAngleType(100); +// assertEquals(obtuse, "Obtuse angle"); +// obtuse = getAngleType(179); +// assertEquals(obtuse, "Obtuse angle"); +// const straight = getAngleType(180); +// assertEquals(straight, "Straight angle"); +// let reflex = getAngleType(181); +// assertEquals(reflex, "Reflex angle"); +// reflex = getAngleType(200); +// assertEquals(reflex, "Reflex angle"); +// reflex = getAngleType(359); +// assertEquals(reflex, "Reflex angle"); +// let invalid = getAngleType(-1); +// assertEquals(invalid, "Invalid angle"); +// invalid = getAngleType(0); +// assertEquals(invalid, "Invalid angle"); +// invalid = getAngleType(360); +// assertEquals(invalid, "Invalid angle"); +// invalid = getAngleType(361); +// assertEquals(invalid, "Invalid angle"); diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js index 6f9cc64ea..fbafa07be 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -30,11 +30,11 @@ function assertEquals(actualOutput, targetOutput) { // What combinations of numerators and denominators should you test? // Example: 1/2 is a proper fraction -assertEquals(isProperFraction(1, 2), true); -assertEquals(isProperFraction(7, 1), false); -assertEquals(isProperFraction(0, 5), true); -assertEquals(isProperFraction(-1, -2), true); -assertEquals(isProperFraction(-2, -1), false); -assertEquals(isProperFraction(-2, 5), true); -assertEquals(isProperFraction(5, -2), false); -assertEquals(isProperFraction(5, 5), false); \ No newline at end of file +// assertEquals(isProperFraction(1, 2), true); +// assertEquals(isProperFraction(7, 1), false); +// assertEquals(isProperFraction(0, 5), true); +// assertEquals(isProperFraction(-1, -2), true); +// assertEquals(isProperFraction(-2, -1), false); +// assertEquals(isProperFraction(-2, 5), true); +// assertEquals(isProperFraction(5, -2), false); +// assertEquals(isProperFraction(5, 5), false); \ No newline at end of file diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js index b91707840..1e82c09c2 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js @@ -43,11 +43,11 @@ function assertEquals(actualOutput, targetOutput) { // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards. // Examples: -assertEquals(getCardValue("9♠"), 9); -assertEquals(getCardValue("A♠"), 11); -assertEquals(getCardValue("2♥"), 2); -assertEquals(getCardValue("10♥"), 10); -assertEquals(getCardValue("Q♦"), 10); +// assertEquals(getCardValue("9♠"), 9); +// assertEquals(getCardValue("A♠"), 11); +// assertEquals(getCardValue("2♥"), 2); +// assertEquals(getCardValue("10♥"), 10); +// assertEquals(getCardValue("Q♦"), 10); //assertEquals(getCardValue("♦Q"), "Invalid card"); ??? //assertEquals(getCardValue("11♦"), "Invalid card"); ??? From dfc3ad2cc3c9ceab8e018aa8c2372e5c5e118826 Mon Sep 17 00:00:00 2001 From: Elisabeth-Matulian Date: Fri, 20 Feb 2026 12:28:54 +0000 Subject: [PATCH 4/5] uncommented-old-tests --- .../implement/1-get-angle-type.js | 60 +++++++++---------- .../implement/2-is-proper-fraction.js | 16 ++--- .../implement/3-get-card-value.js | 14 ++--- 3 files changed, 45 insertions(+), 45 deletions(-) diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js index f2fb9c160..e0361aeb3 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js @@ -38,36 +38,36 @@ function assertEquals(actualOutput, targetOutput) { // TODO: Write tests to cover all cases, including boundary and invalid cases. // Example: Identify Right Angles -// const right = getAngleType(90); -// assertEquals(right, "Right angle"); -// let acute = getAngleType(1); -// assertEquals(acute, "Acute angle"); -// acute = getAngleType(45); -// assertEquals(acute, "Acute angle"); -// acute = getAngleType(89); -// assertEquals(acute, "Acute angle"); -// let obtuse = getAngleType(91); -// assertEquals(obtuse, "Obtuse angle"); -// obtuse = getAngleType(100); -// assertEquals(obtuse, "Obtuse angle"); -// obtuse = getAngleType(179); -// assertEquals(obtuse, "Obtuse angle"); -// const straight = getAngleType(180); -// assertEquals(straight, "Straight angle"); -// let reflex = getAngleType(181); -// assertEquals(reflex, "Reflex angle"); -// reflex = getAngleType(200); -// assertEquals(reflex, "Reflex angle"); -// reflex = getAngleType(359); -// assertEquals(reflex, "Reflex angle"); -// let invalid = getAngleType(-1); -// assertEquals(invalid, "Invalid angle"); -// invalid = getAngleType(0); -// assertEquals(invalid, "Invalid angle"); -// invalid = getAngleType(360); -// assertEquals(invalid, "Invalid angle"); -// invalid = getAngleType(361); -// assertEquals(invalid, "Invalid angle"); +const right = getAngleType(90); +assertEquals(right, "Right angle"); +let acute = getAngleType(1); +assertEquals(acute, "Acute angle"); +acute = getAngleType(45); +assertEquals(acute, "Acute angle"); +acute = getAngleType(89); +assertEquals(acute, "Acute angle"); +let obtuse = getAngleType(91); +assertEquals(obtuse, "Obtuse angle"); +obtuse = getAngleType(100); +assertEquals(obtuse, "Obtuse angle"); +obtuse = getAngleType(179); +assertEquals(obtuse, "Obtuse angle"); +const straight = getAngleType(180); +assertEquals(straight, "Straight angle"); +let reflex = getAngleType(181); +assertEquals(reflex, "Reflex angle"); +reflex = getAngleType(200); +assertEquals(reflex, "Reflex angle"); +reflex = getAngleType(359); +assertEquals(reflex, "Reflex angle"); +let invalid = getAngleType(-1); +assertEquals(invalid, "Invalid angle"); +invalid = getAngleType(0); +assertEquals(invalid, "Invalid angle"); +invalid = getAngleType(360); +assertEquals(invalid, "Invalid angle"); +invalid = getAngleType(361); +assertEquals(invalid, "Invalid angle"); diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js index fbafa07be..6f9cc64ea 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js @@ -30,11 +30,11 @@ function assertEquals(actualOutput, targetOutput) { // What combinations of numerators and denominators should you test? // Example: 1/2 is a proper fraction -// assertEquals(isProperFraction(1, 2), true); -// assertEquals(isProperFraction(7, 1), false); -// assertEquals(isProperFraction(0, 5), true); -// assertEquals(isProperFraction(-1, -2), true); -// assertEquals(isProperFraction(-2, -1), false); -// assertEquals(isProperFraction(-2, 5), true); -// assertEquals(isProperFraction(5, -2), false); -// assertEquals(isProperFraction(5, 5), false); \ No newline at end of file +assertEquals(isProperFraction(1, 2), true); +assertEquals(isProperFraction(7, 1), false); +assertEquals(isProperFraction(0, 5), true); +assertEquals(isProperFraction(-1, -2), true); +assertEquals(isProperFraction(-2, -1), false); +assertEquals(isProperFraction(-2, 5), true); +assertEquals(isProperFraction(5, -2), false); +assertEquals(isProperFraction(5, 5), false); \ No newline at end of file diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js index 1e82c09c2..1460324f6 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js @@ -43,13 +43,13 @@ function assertEquals(actualOutput, targetOutput) { // TODO: Write tests to cover all outcomes, including throwing errors for invalid cards. // Examples: -// assertEquals(getCardValue("9♠"), 9); -// assertEquals(getCardValue("A♠"), 11); -// assertEquals(getCardValue("2♥"), 2); -// assertEquals(getCardValue("10♥"), 10); -// assertEquals(getCardValue("Q♦"), 10); -//assertEquals(getCardValue("♦Q"), "Invalid card"); ??? -//assertEquals(getCardValue("11♦"), "Invalid card"); ??? +assertEquals(getCardValue("9♠"), 9); +assertEquals(getCardValue("A♠"), 11); +assertEquals(getCardValue("2♥"), 2); +assertEquals(getCardValue("10♥"), 10); +assertEquals(getCardValue("Q♦"), 10); +assertEquals(getCardValue("♦Q"), "Invalid card"); +assertEquals(getCardValue("11♦"), "Invalid card"); // Handling invalid cards try { From c47b556c4238179f603650512364c0cb3ba6716b Mon Sep 17 00:00:00 2001 From: Elisabeth-Matulian Date: Sat, 21 Feb 2026 18:33:18 +0000 Subject: [PATCH 5/5] solved-try-catch-test-issue --- .../implement/3-get-card-value.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js index 1460324f6..c12e9e35c 100644 --- a/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js +++ b/Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js @@ -48,9 +48,6 @@ assertEquals(getCardValue("A♠"), 11); assertEquals(getCardValue("2♥"), 2); assertEquals(getCardValue("10♥"), 10); assertEquals(getCardValue("Q♦"), 10); -assertEquals(getCardValue("♦Q"), "Invalid card"); -assertEquals(getCardValue("11♦"), "Invalid card"); - // Handling invalid cards try { getCardValue("invalid"); @@ -58,5 +55,16 @@ try { // This line will not be reached if an error is thrown as expected console.error("Error was not thrown for invalid card"); } catch (e) {} +try { + getCardValue("♦Q"); + + // This line will not be reached if an error is thrown as expected + console.error("Error was not thrown for invalid card"); +} catch (e) {} +try { + getCardValue("11♦"); + // This line will not be reached if an error is thrown as expected + console.error("Error was not thrown for invalid card"); +} catch (e) {} // What other invalid card cases can you think of?