rewrite all three tests in Jest with full boundary coverage

Author: remimarcelle

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -2,6 +2,9 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const getAngleType = require("../implement/1-get-angle-type");
 
+// Jest docs: https://jestjs.io/docs/getting-started
+// freeCodeCamp intro to testing: https://www.freecodecamp.org/news/how-to-start-unit-testing-javascript
+
 // TODO: Write tests in Jest syntax to cover all cases/outcomes,
 // including boundary and invalid cases.
 
@@ -14,7 +17,33 @@ test(`should return "Acute angle" when (0 < angle < 90)`, () => {
 });
 
 // Case 2: Right angle
+test(`should return "Right angle" when angle is exactly 90`, () => {
+  expect(getAngleType(90)).toEqual("Right angle");
+});
+
 // Case 3: Obtuse angles
+test(`should return "Obtuse angle" when (90 < angle < 180)`, () => {
+  expect(getAngleType(91)).toEqual("Obtuse angle"); // boundary: just above 90
+  expect(getAngleType(120)).toEqual("Obtuse angle"); // normal obtuse angle
+  expect(getAngleType(179)).toEqual("Obtuse angle"); // boundary: just below 180
+});
+
 // Case 4: Straight angle
+test(`should return "Straight angle" when angle is exactly 180`, () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
+
 // Case 5: Reflex angles
+test(`should return "Reflex angle" when (180 < angle < 360)`, () => {
+  expect(getAngleType(181)).toEqual("Reflex angle"); // boundary: just above 180
+  expect(getAngleType(270)).toEqual("Reflex angle"); // normal reflex angle
+  expect(getAngleType(359)).toEqual("Reflex angle"); // boundary: just below 360
+});
+
 // Case 6: Invalid angles
+test(`should return "Invalid angle" for angles outside valid range`, () => {
+  expect(getAngleType(0)).toEqual("Invalid angle"); // boundary: exactly 0
+  expect(getAngleType(360)).toEqual("Invalid angle"); // boundary: exactly 360
+  expect(getAngleType(-10)).toEqual("Invalid angle"); // negative number
+  expect(getAngleType(400)).toEqual("Invalid angle"); // over 360
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -8,3 +8,22 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 test(`should return false when denominator is zero`, () => {
   expect(isProperFraction(1, 0)).toEqual(false);
 });
+
+// Proper fractions: numerator smaller than denominator
+test("should return true for a proper fraction", () => {
+  expect(isProperFraction(1, 2)).toEqual(true); // basic proper fraction
+  expect(isProperFraction(3, 4)).toEqual(true);
+  expect(isProperFraction(-1, 2)).toEqual(true); // negative numerator still proper
+  expect(isProperFraction(0, 5)).toEqual(true); // 0/5 = 0, which is proper
+});
+
+// Improper fractions: numerator greater than denominator
+test("should return false for an improper fraction", () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
+  expect(isProperFraction(5, 3)).toEqual(false);
+});
+
+// Boundary: equal numerator and denominator - 4/4 = 1, a whole number not a fraction
+test("should return false when numerator equals denominator", () => {
+  expect(isProperFraction(4, 4)).toEqual(false);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -7,6 +7,7 @@ const getCardValue = require("../implement/3-get-card-value");
 // Case 1: Ace (A)
 test(`Should return 11 when given an ace card`, () => {
   expect(getCardValue("A♠")).toEqual(11);
+  expect(getCardValue("A♥")).toEqual(11);
 });
 
 // Suggestion: Group the remaining test data into these categories:
@@ -18,3 +19,25 @@ test(`Should return 11 when given an ace card`, () => {
 // please refer to the Jest documentation:
 // https://jestjs.io/docs/expect#tothrowerror
 
+// Number cards -> return their numeric value (2-10)
+test("should return the numeric value for number cards", () => {
+  expect(getCardValue("2♦")).toEqual(2); // boundary: lowest number card
+  expect(getCardValue("9♣")).toEqual(9);
+  expect(getCardValue("10♥")).toEqual(10); // boundary: highest number card
+});
+
+//Face cards -> Jack, Queen and King are all worth 10
+test("should return 10 for face cards (J, Q, K)", () => {
+  expect(getCardValue("J♣")).toEqual(10);
+  expect(getCardValue("Q♦")).toEqual(10);
+  expect(getCardValue("K♠")).toEqual(10);
+});
+
+// Invalid cards -> function should throw an error
+// We wrap the call in () => so Jest can catch the error without crashing the test
+// MDN on arrow functions: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions
+test("should throw an error for invalid cards", () => {
+  expect(() => getCardValue("invalid")).toThrow();
+  expect(() => getCardValue("1♠")).toThrow(); // 1 is not a valid rank
+  expect(() => getCardValue("")).toThrow(); // empty string
+});