Merge pull request #29 from CodeHex16/hotfix-bazzan-sprint15

fix: change context on messages

Author: lucaribon

app/services/llm_response_service.py

@@ -50,7 +50,7 @@ def _get_context(self, question: str) -> Union[str, list[str]]:
             return output
         except ValueError as ve:
             raise HTTPException(
-                status_code=500, detail=f"Error getting context: {str(ve)}"
+                status_code=404, detail=f"Error getting context: {str(ve)}"
             )
         except Exception as e:
             logger.error(f"Unexpected error in _get_context for question '{question}': {str(e)}", exc_info=True)
@@ -59,26 +59,31 @@ def _get_context(self, question: str) -> Union[str, list[str]]:
             )
 
     def generate_llm_response(self, question: schemas.Question) -> StreamingResponse:
-        context = self._get_context(question.question)
+        try:
+            context = self._get_context(question.question)
+        except HTTPException as e:
+            logger.error(f"No context found", exc_info=True)
+            context = ""
+
         formatted_messages = ""
-        context_messages = ""
+        # context_messages = ""
 
         if question.messages:
             formatted_messages = "\n".join(
                 [f"{msg.sender}: {msg.content}" for msg in question.messages]
             )            
-            context_messages = self._get_context(formatted_messages)
+            # context_messages = self._get_context(formatted_messages)
 
         messages = [
             SystemMessage(self._CHATBOT_INSTRUCTIONS),
+            SystemMessage(f"Conversazione precedente: {formatted_messages}"),
             SystemMessage(
-                f"Contesto: {context}\n{context_messages}",
+                f"Contesto: {context}",
             ),
-            SystemMessage(f"Conversazione precedente: {formatted_messages}"),
             HumanMessage(f"Domanda a cui devi rispondere: {question}"),
         ]
         print()
-        print(f"PROMPT: {context} {context_messages}")
+        print(f"PROMPT: {context}")
         print()
         try:
             stream_response = self._LLM._model.astream(messages)

tests/services/test_llm_response_services.py

@@ -68,8 +68,8 @@ def test_llm_response_service_get_context_false(monkeypatch):
     with pytest.raises(HTTPException) as excinfo:
         llm_response_service._get_context(question)
     assert (
-        excinfo.value.status_code == 500
-    ), "Should raise HTTPException with status code 500"
+        excinfo.value.status_code == 404
+    ), "Should raise HTTPException with status code 404"
     assert str(excinfo.value.detail).startswith(
         "Error getting context:"
     ), "Should raise HTTPException with the correct error message"