format markdown/marcli + get rid of warnings#5
Open
am-kantox wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ❤ this implementation and I started translating my libs to it.
Here is a glitch of me using your library (applies to all libs, from elixir core down to nimble_××× family,) I am to bother you with insignificant PRs doing what nobody but me needs.
I included a fix for several warnings and credo check disabling, but if you wish I might extract these to another PR.
This one is about making it even more friendly to the user. Luckily enough, the hard part was already there, so I came with cosmetic only.
--format markdownand--format marcli(for the latter one needs to explicitly add{:marcli, "~> 0.3"}dependency to their project.) The outcome looks like:And (please note suggestions for suppressing):