Commander deck "Toothy, Imaginary Friend" has > 1 copy of "Pir, Imaginative Rascal"

[rpherbig]

Describe the bug
When I try to make a Commander game with the deck "Toothy, Imaginary Friend" selected, I get an error (see screenshot).

To Reproduce
Steps to reproduce the behavior:

1. Go to Hme
2. Select format check box for "Commander"
3. Select the AI player
4. Give them the deck "Toothy, Imaginary Friend"
5. Hit Start

Expected behavior
The game starts

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser: n/a
• Version: 2.0.10-SNAPSHOT-02.17

Smartphone (please complete the following information):
n/a

Additional context
n/a

[kojotak]

I have found the bug, but I don't know how to fix it 🙈 . The problem seems to be in DeckgenUtil.java:720 in

                if (partners.size() > 0) {
                    selectedPartner = partners.get(MyRandom.getRandom().nextInt(partners.size()));
                    preSelectedCards.removeAll(StaticData.instance().getCommonCards().getAllCards(selectedPartner.getName()));
                }

The selectedPartner is Pir, Imaginative Rascal from BBD edition and N.A. collectorNumber. But on the next line, the getAllCards finds two Pirs - one from SLD with collectorNumber 1050, second from BBD with collectorNumber 11. Here lies the problem - the preSelectedCards removes nothing, since the equals is comparing collectorNumbers. The result is, that Pir is added into deck twice: first time as a partner and second time into main deck.

[rpherbig]

@kojotak I just ran into a similar error with the Commander deck "Ludevic, Necro-Alchemist": the problematic card was "Kydele, Chosen of Kruphix".

Will your PR also fix that one?

[kojotak]

@rpherbig yes, I'm able to start a commander game with generated deck for Ludevic, Necro-Alchemist:

Still not sure whether #10000 fixes the cause or the effect.

[github-actions]

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

[rpherbig]

bump. this still happens