Counter Type Meta Issue

[Hanmac]

• use Translatable Interface for better name. Might Translate them later in the Future.
• Icon for Keyword Counter used in Choice Dialog.
• Static ability for +X/+Y Counter
  • Allow Custom variants?
• Use List File for Custom Counters, might move some Enum Counters there that aren't used in Code

The Name only really has two modes, might just generate directly:

• P1P1 to +1/+1 for PTCounter
• Capitalize for anything else.

Types of CounterTypes:

• CounterEnumType: the ones that are REALLY Hard Coded in the Java Code (has Color)
• CounterCustomType: the ones that will be defined in a List like CreatureTypes. (has Color)
• CounterKeywordType: the ones that are Keywords by the rules, and fallback to anything else. (has Keyword Icon)

Possible CounterCustomType List:
KeyName=Desc,R,G,B

CAGE=CAGE,155,155,155

(Dialog-Name will be Cage)

---

For Cleanup and Custom Counters: List of Counters that are used in Code like P1P1 and M1M1, separate them between Rules Code and AI code:

Rules:

• SHIELD, STUN and FINALITY Counter for their Replacement Effects
• MANABOND for their Static
• DEFENSE for Battle/Siege
• LORE for Sagas
• LOYALTY for Planeswalker
• DREAM for some (not more than 7) rules
• TIME for TimeTravel.
• POISON, ENERGY, EXPERIENCE, RAD (and Ticket) for Player

AI:

• QUEST for Proto-Sagas (and some legendary?)
• FADE for Fading
• TIME for Vanishing
• CHARGE for Station
• KI for some Legendary
• POISON, ENERGY, EXPERIENCE, RAD and Ticket for Player
• ICE for darkDepths and Storage Lands
• CAGE for MairsilThePretender
• BURDEN for TheOneRing
• AI uses some counter types in the isNegativeCounter and isUselessCounter functions. Helper might be enough for these cases?

[Jetz72]

Static ability for +X/+Y Counter

Allow Custom variants?

Not a system I'm too familiar with, but I'd be in favor of supporting custom static abilities in counter-type definitions. We could possibly move Shield, Stun, and Finality counters over to something like that if we had a general enough implementation.

Though if I recall correctly, there's a subtle technical distinction between Shield counters and the other two - I think the former uses a single universal RE, while the latter creates an RE for each permanent with the respective counter. I don't know if the distinction is meaningful.