Android Lint error

[edwardhuerta]

I generated a simple content provider and I get this when i run Android Lint on the newly generated classes:

Do not place Android context classes in static fields (static reference to MyDataStoreProviderSQLiteOpenHelper which has field mContext pointing to Context); this is a memory leak (and also breaks Instant Run)

This is located in the generated ...SQLiteOpenHelper extends SQLiteOpenHelper class.

[BoD]

This warning can safely be ignored.
You can add @SuppressLint("StaticFieldLeak") manually for now, and I will add it to the generated code in the next version.

[edwardhuerta]

Safely ignore this? If lint says it's a problem, then I would think that it cannot be ignored. Can you elaborate on why it is safe to ignore that error?

…

On 5 Dec 2016 3:02 p.m., "Benoit Lubek" ***@***.***> wrote: This warning can safely be ignored. You can add @SuppressLint("StaticFieldLeak") manually for now, and I will add it to the generated code in the next version. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#103 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKzuTR9DR7K-chAzU-bfSVTMjQqc7sfQks5rFBmIgaJpZM4LDlXt> .

[BoD]

If lint says it's a problem, then I would think that it cannot be ignored.

Sorry, you are wrong about this. The problems reported by lint have different severities (errors, warnings, info, etc.). This one is a warning.
Moreover, static code analyzers are not bullet proof, sometimes they are overzealous - at times they are even plain wrong. A developer should always think and make sure that the reported problem really is one, and not blindly try to "fix" it. That's why they have a mechanism to ignore reported problems (@SuppressLint).

Can you elaborate on why it is safe to ignore that error?

In this particular case, the generated code already has something to say about this (look at the comment inside getInstance).
As you can see, we only keep a reference to the Application Context. Which is a singleton.