Audio S/PDIF playback reports incorrect LBA

[AidanHolmes]

LBA returned from cdromGetAudioPlaybackStatus reports incorrect LBA where audio_get_file_position() / 2352 is only the relative LBA from the start of the audio file and not the CD LBA. This causes issues with any applications calling read sub channel to check audio playback position.

Note that the reverse is also true when using audio_set_file_position which cannot translate an absolute CD LBA to a relative fpos in an audio file track. Usage of this function from audio_spdif.cpp should consider the current track start LBA and deduct from the absolute LBA before calling audio_set_file_position.

This occurs on a Pico W (2040) using the latest Pico_Audio_SPDIF build

[erichelgeson]

Thanks for the report! I did some major re-work here - could you pleas test the firmware built in the #355?

[AidanHolmes]

I tested with a build of eric/353 branch. The playback was showing track minutes and seconds now. I did experience a crash and attached the logs here. It seems to crash when the 5th playback is attempted

log.txt

err.txt

[AidanHolmes]

Here is another test run with fresh logs and an err crash log

log.txt
err.txt

[erichelgeson]

Pushed a fix I think - some dynamic heap allocation that was not necessary. Thanks for testing!

[AidanHolmes]

A further test shows that this is working now and changes to tracks can be made many times.