From ab6653ec8ec7fed7e535f12f3b8c9b8ded5d1226 Mon Sep 17 00:00:00 2001 From: Roberto Date: Wed, 4 Mar 2026 10:16:26 +0000 Subject: [PATCH 1/2] Bugfix: hide screen when not active --- BlocksScreen/lib/panels/widgets/probeHelperPage.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/BlocksScreen/lib/panels/widgets/probeHelperPage.py b/BlocksScreen/lib/panels/widgets/probeHelperPage.py index 34447db9..c7d68a21 100644 --- a/BlocksScreen/lib/panels/widgets/probeHelperPage.py +++ b/BlocksScreen/lib/panels/widgets/probeHelperPage.py @@ -527,11 +527,16 @@ def on_manual_probe_update(self, update: dict) -> None: if update.get("is_active"): if not self.isVisible(): self.request_page_view.emit() - self.helper_initialize = False self.helper_start = True self._hide_option_cards() self._toggle_tool_buttons(True) + else: + self._show_option_cards() + self._toggle_tool_buttons(False) + self.helper_initialize = False + self.helper_start = False + if update.get("z_position_upper"): self.old_offset_info.setText(f"{update.get('z_position_upper'):.4f} mm") From b2c537772455851c048080f121c8130b4ea1126d Mon Sep 17 00:00:00 2001 From: Roberto Date: Wed, 4 Mar 2026 10:25:23 +0000 Subject: [PATCH 2/2] Refactor : optimzied code --- .../lib/panels/widgets/probeHelperPage.py | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/BlocksScreen/lib/panels/widgets/probeHelperPage.py b/BlocksScreen/lib/panels/widgets/probeHelperPage.py index c7d68a21..372499ef 100644 --- a/BlocksScreen/lib/panels/widgets/probeHelperPage.py +++ b/BlocksScreen/lib/panels/widgets/probeHelperPage.py @@ -524,19 +524,18 @@ def on_manual_probe_update(self, update: dict) -> None: # if update.get("z_position_lower"): # f"{update.get('z_position_lower'):.4f} mm" - if update.get("is_active"): - if not self.isVisible(): - self.request_page_view.emit() - self.helper_initialize = False - self.helper_start = True + is_active = update.get("is_active", False) + if is_active and not self.isVisible(): + self.request_page_view.emit() + # Shared state updates + self.helper_initialize = False + self.helper_start = is_active + # UI updates + self._toggle_tool_buttons(is_active) + if is_active: self._hide_option_cards() - self._toggle_tool_buttons(True) else: self._show_option_cards() - self._toggle_tool_buttons(False) - self.helper_initialize = False - self.helper_start = False - if update.get("z_position_upper"): self.old_offset_info.setText(f"{update.get('z_position_upper'):.4f} mm")