Expired SAS token logs error

[AndreRicardo-Zoetis]

Expected Behavior

When a SAS token expires it should be refreshed and not report an error in the logs.

Assumption on my part: this seems to be the normal operating scenario for ADU, only renewing the SAS token once the old one is expired.

Current Behavior

IOTHUB_CLIENT_CONNECTION_EXPIRED_SAS_TOKEN causes a log error with "IoTHub connection is broken." for a scenario that is expected to happen, to renew the SAS token.

When support looks at the logs reports these as a problem because "broken" is such a strong word, ideally informing something along the lines of "IoTHub connection SAS token has expired, renewing connection." could possibly reduce confusion.

Steps to Reproduce

Provide a detailed set of steps to reproduce the bug.

1. Connect ADU, can be with symmetric key.
2. Wait 48 mins and 38 seconds.
3. See the IoTHub connection is broken.

Device Information

• Host OS [e.g. Ubuntu 22.04]:
  Debian 12 (I believe this is irrelevant also happens with Debian 11 or other OS)
• Architecture [e.g. amd64, arm32, arm64]:
  amd64
• Provisioning Method:
  Symmetric key
• *DU Agent Version (run 'sudo -u adu /usr/bin/AducIotAgent -v'):
  sudo -u adu out/bin/AducIotAgent -v
  1.2.0

Logs

Additional Information

Please provide any additional information that may be helpful in understanding the issue.

Related code:

iot-hub-device-update/src/communication_managers/iothub_communication_manager/src/iothub_communication_manager.c

Line 224 in b60dcf6

Log_Error("IoTHub connection is broken.");

[AndreRicardo-Zoetis]

Any feedback on this?

We currently are monitoring for errors in our device logs to be on the lookout for issues, this is quite a red herring as anyone looking at the logs identifies this error and "is broken" as a problem, while we see it about 30 times a day every time the SAS token expires.