From fcb8b661e46ac461293569a2478a49f5f3caef83 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 25 Feb 2026 21:59:57 +0000 Subject: [PATCH 1/2] Initial plan From d9fe4f04be131d70348700b4ca279072d232e4e0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 25 Feb 2026 22:37:08 +0000 Subject: [PATCH 2/2] feat: change dab init default for request-body-strict to false Co-authored-by: JerryNixon <1749983+JerryNixon@users.noreply.github.com> --- src/Cli.Tests/ConfigGeneratorTests.cs | 2 +- src/Cli.Tests/EndToEndTests.cs | 2 +- ...dProcedureWithRestMethodsAndGraphQLOperations.verified.txt | 2 +- ...dAfterAddingEntityWithSourceAsStoredProcedure.verified.txt | 2 +- ...tedAfterAddingEntityWithSourceWithDefaultType.verified.txt | 2 +- ...GeneratedAfterAddingEntityWithoutIEnumerables.verified.txt | 2 +- .../EndToEndTests.TestInitForCosmosDBNoSql.verified.txt | 2 +- ...ts.TestUpdatingStoredProcedureWithRestMethods.verified.txt | 2 +- ...dProcedureWithRestMethodsAndGraphQLOperations.verified.txt | 2 +- .../Snapshots/InitTests.CosmosDbNoSqlDatabase.verified.txt | 2 +- .../InitTests.CosmosDbPostgreSqlDatabase.verified.txt | 2 +- ...erentAuthenticationProviders_171ea8114ff71814.verified.txt | 2 +- ...erentAuthenticationProviders_2df7a1794712f154.verified.txt | 2 +- ...erentAuthenticationProviders_59fe1a10aa78899d.verified.txt | 2 +- ...erentAuthenticationProviders_b95b637ea87f16a7.verified.txt | 2 +- ...erentAuthenticationProviders_daacbd948b7ef72f.verified.txt | 2 +- ...raphQLPathWithoutStartingSlashWillHaveItAdded.verified.txt | 2 +- src/Cli.Tests/Snapshots/InitTests.MsSQLDatabase.verified.txt | 2 +- ...s.RestPathWithoutStartingSlashWillHaveItAdded.verified.txt | 2 +- ...TestInitializingConfigWithoutConnectionString.verified.txt | 2 +- ...Tests.TestSpecialCharactersInConnectionString.verified.txt | 2 +- ...nWithMultipleMutationOptions_0546bef37027a950.verified.txt | 2 +- ...nWithMultipleMutationOptions_0ac567dd32a2e8f5.verified.txt | 2 +- ...nWithMultipleMutationOptions_0c06949221514e77.verified.txt | 2 +- ...nWithMultipleMutationOptions_18667ab7db033e9d.verified.txt | 2 +- ...nWithMultipleMutationOptions_2f42f44c328eb020.verified.txt | 2 +- ...nWithMultipleMutationOptions_3243d3f3441fdcc1.verified.txt | 2 +- ...nWithMultipleMutationOptions_53350b8b47df2112.verified.txt | 2 +- ...nWithMultipleMutationOptions_6584e0ec46b8a11d.verified.txt | 2 +- ...nWithMultipleMutationOptions_81cc88db3d4eecfb.verified.txt | 2 +- ...nWithMultipleMutationOptions_8ea187616dbb5577.verified.txt | 2 +- ...nWithMultipleMutationOptions_905845c29560a3ef.verified.txt | 2 +- ...nWithMultipleMutationOptions_b2fd24fab5b80917.verified.txt | 2 +- ...nWithMultipleMutationOptions_bd7cd088755287c9.verified.txt | 2 +- ...nWithMultipleMutationOptions_d2eccba2f836b380.verified.txt | 2 +- ...nWithMultipleMutationOptions_d463eed7fe5e4bbe.verified.txt | 2 +- ...nWithMultipleMutationOptions_d5520dd5c33f7b8d.verified.txt | 2 +- ...nWithMultipleMutationOptions_eab4a6010e602b59.verified.txt | 2 +- ...nWithMultipleMutationOptions_ecaa688829b4030e.verified.txt | 2 +- src/Cli/Commands/InitOptions.cs | 2 +- src/Cli/ConfigGenerator.cs | 2 +- src/Config/ObjectModel/RestRuntimeOptions.cs | 4 ++-- 42 files changed, 43 insertions(+), 43 deletions(-) diff --git a/src/Cli.Tests/ConfigGeneratorTests.cs b/src/Cli.Tests/ConfigGeneratorTests.cs index 59a7f7b8dd..4729e7179a 100644 --- a/src/Cli.Tests/ConfigGeneratorTests.cs +++ b/src/Cli.Tests/ConfigGeneratorTests.cs @@ -156,7 +156,7 @@ public void TestSpecialCharactersInConnectionString() ""rest"": { ""enabled"": true, ""path"": ""/api"", - ""request-body-strict"": true + ""request-body-strict"": false }, ""graphql"": { ""enabled"": true, diff --git a/src/Cli.Tests/EndToEndTests.cs b/src/Cli.Tests/EndToEndTests.cs index 99a9b77b6e..34b0aa90ae 100644 --- a/src/Cli.Tests/EndToEndTests.cs +++ b/src/Cli.Tests/EndToEndTests.cs @@ -1223,7 +1223,7 @@ public void TestEnabledDisabledFlagsForApis( [DataTestMethod] [DataRow(true, false, DisplayName = "dab init command specifies --rest.request-body-strict as false - REST request body allows extraneous fields.")] [DataRow(true, true, DisplayName = "dab init command specifies --rest.request-body-strict as true - REST request body doesn't allow extraneous fields.")] - [DataRow(false, true, DisplayName = "dab init command does not include --rest.request-body-strict flag. The default behavior is followed - REST request body doesn't allow extraneous fields.")] + [DataRow(false, false, DisplayName = "dab init command does not include --rest.request-body-strict flag. The default behavior is followed - REST request body allows extraneous fields.")] public void TestRestRequestBodyStrictMode(bool includeRestRequestBodyStrictFlag, bool isRequestBodyStrict) { string[] initArgs = { "init", "-c", TEST_RUNTIME_CONFIG_FILE, "--host-mode", "development", "--database-type", "mssql", diff --git a/src/Cli.Tests/Snapshots/EndToEndTests.TestAddingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt b/src/Cli.Tests/Snapshots/EndToEndTests.TestAddingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt index 3fa1fbc14e..c45b8a6021 100644 --- a/src/Cli.Tests/Snapshots/EndToEndTests.TestAddingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt +++ b/src/Cli.Tests/Snapshots/EndToEndTests.TestAddingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceAsStoredProcedure.verified.txt b/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceAsStoredProcedure.verified.txt index 76ea01dfca..13228045d7 100644 --- a/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceAsStoredProcedure.verified.txt +++ b/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceAsStoredProcedure.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceWithDefaultType.verified.txt b/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceWithDefaultType.verified.txt index 3a8c738a70..43546fad3b 100644 --- a/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceWithDefaultType.verified.txt +++ b/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithSourceWithDefaultType.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithoutIEnumerables.verified.txt b/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithoutIEnumerables.verified.txt index df2cd4b009..c162eda70f 100644 --- a/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithoutIEnumerables.verified.txt +++ b/src/Cli.Tests/Snapshots/EndToEndTests.TestConfigGeneratedAfterAddingEntityWithoutIEnumerables.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/EndToEndTests.TestInitForCosmosDBNoSql.verified.txt b/src/Cli.Tests/Snapshots/EndToEndTests.TestInitForCosmosDBNoSql.verified.txt index 1b14a3a7f0..5c9fa8e8bb 100644 --- a/src/Cli.Tests/Snapshots/EndToEndTests.TestInitForCosmosDBNoSql.verified.txt +++ b/src/Cli.Tests/Snapshots/EndToEndTests.TestInitForCosmosDBNoSql.verified.txt @@ -10,7 +10,7 @@ Rest: { Enabled: false, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethods.verified.txt b/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethods.verified.txt index 62d9e237b5..fd8620a5b3 100644 --- a/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethods.verified.txt +++ b/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethods.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt b/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt index fa8b16e739..b9e54931ae 100644 --- a/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt +++ b/src/Cli.Tests/Snapshots/EndToEndTests.TestUpdatingStoredProcedureWithRestMethodsAndGraphQLOperations.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.CosmosDbNoSqlDatabase.verified.txt b/src/Cli.Tests/Snapshots/InitTests.CosmosDbNoSqlDatabase.verified.txt index 9d5458c0ee..cd926aae03 100644 --- a/src/Cli.Tests/Snapshots/InitTests.CosmosDbNoSqlDatabase.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.CosmosDbNoSqlDatabase.verified.txt @@ -10,7 +10,7 @@ Rest: { Enabled: false, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.CosmosDbPostgreSqlDatabase.verified.txt b/src/Cli.Tests/Snapshots/InitTests.CosmosDbPostgreSqlDatabase.verified.txt index 51f6ad8d95..cb74999191 100644 --- a/src/Cli.Tests/Snapshots/InitTests.CosmosDbPostgreSqlDatabase.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.CosmosDbPostgreSqlDatabase.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-endpoint, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_171ea8114ff71814.verified.txt b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_171ea8114ff71814.verified.txt index 978d1a253b..ee4d2081e4 100644 --- a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_171ea8114ff71814.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_171ea8114ff71814.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_2df7a1794712f154.verified.txt b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_2df7a1794712f154.verified.txt index 402bf4d2bc..2645d71022 100644 --- a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_2df7a1794712f154.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_2df7a1794712f154.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_59fe1a10aa78899d.verified.txt b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_59fe1a10aa78899d.verified.txt index ab71a40f03..65448d1991 100644 --- a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_59fe1a10aa78899d.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_59fe1a10aa78899d.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_b95b637ea87f16a7.verified.txt b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_b95b637ea87f16a7.verified.txt index 25e3976685..a95f385715 100644 --- a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_b95b637ea87f16a7.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_b95b637ea87f16a7.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_daacbd948b7ef72f.verified.txt b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_daacbd948b7ef72f.verified.txt index 140f017b78..9ea6bc5653 100644 --- a/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_daacbd948b7ef72f.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.EnsureCorrectConfigGenerationWithDifferentAuthenticationProviders_daacbd948b7ef72f.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.GraphQLPathWithoutStartingSlashWillHaveItAdded.verified.txt b/src/Cli.Tests/Snapshots/InitTests.GraphQLPathWithoutStartingSlashWillHaveItAdded.verified.txt index a3a056ac0a..4b63ed5e2d 100644 --- a/src/Cli.Tests/Snapshots/InitTests.GraphQLPathWithoutStartingSlashWillHaveItAdded.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.GraphQLPathWithoutStartingSlashWillHaveItAdded.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.MsSQLDatabase.verified.txt b/src/Cli.Tests/Snapshots/InitTests.MsSQLDatabase.verified.txt index f40350c4da..d44a87d38f 100644 --- a/src/Cli.Tests/Snapshots/InitTests.MsSQLDatabase.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.MsSQLDatabase.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.RestPathWithoutStartingSlashWillHaveItAdded.verified.txt b/src/Cli.Tests/Snapshots/InitTests.RestPathWithoutStartingSlashWillHaveItAdded.verified.txt index b792d41c9f..a375ab3c07 100644 --- a/src/Cli.Tests/Snapshots/InitTests.RestPathWithoutStartingSlashWillHaveItAdded.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.RestPathWithoutStartingSlashWillHaveItAdded.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /abc, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.TestInitializingConfigWithoutConnectionString.verified.txt b/src/Cli.Tests/Snapshots/InitTests.TestInitializingConfigWithoutConnectionString.verified.txt index 173960d7b1..2cc3d35e9c 100644 --- a/src/Cli.Tests/Snapshots/InitTests.TestInitializingConfigWithoutConnectionString.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.TestInitializingConfigWithoutConnectionString.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.TestSpecialCharactersInConnectionString.verified.txt b/src/Cli.Tests/Snapshots/InitTests.TestSpecialCharactersInConnectionString.verified.txt index 25e3976685..a95f385715 100644 --- a/src/Cli.Tests/Snapshots/InitTests.TestSpecialCharactersInConnectionString.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.TestSpecialCharactersInConnectionString.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0546bef37027a950.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0546bef37027a950.verified.txt index 63f0da701c..ab7da96e44 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0546bef37027a950.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0546bef37027a950.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0ac567dd32a2e8f5.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0ac567dd32a2e8f5.verified.txt index f40350c4da..d44a87d38f 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0ac567dd32a2e8f5.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0ac567dd32a2e8f5.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0c06949221514e77.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0c06949221514e77.verified.txt index e59070d692..f2d6f2996e 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0c06949221514e77.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_0c06949221514e77.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_18667ab7db033e9d.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_18667ab7db033e9d.verified.txt index f7de35b7ae..eccdef1309 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_18667ab7db033e9d.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_18667ab7db033e9d.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_2f42f44c328eb020.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_2f42f44c328eb020.verified.txt index 63f0da701c..ab7da96e44 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_2f42f44c328eb020.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_2f42f44c328eb020.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_3243d3f3441fdcc1.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_3243d3f3441fdcc1.verified.txt index f7de35b7ae..eccdef1309 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_3243d3f3441fdcc1.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_3243d3f3441fdcc1.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_53350b8b47df2112.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_53350b8b47df2112.verified.txt index 75613db959..75df604b4e 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_53350b8b47df2112.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_53350b8b47df2112.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_6584e0ec46b8a11d.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_6584e0ec46b8a11d.verified.txt index d93aac7dc6..320c1983da 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_6584e0ec46b8a11d.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_6584e0ec46b8a11d.verified.txt @@ -10,7 +10,7 @@ Rest: { Enabled: false, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_81cc88db3d4eecfb.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_81cc88db3d4eecfb.verified.txt index 640815babb..7205cc94c5 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_81cc88db3d4eecfb.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_81cc88db3d4eecfb.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_8ea187616dbb5577.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_8ea187616dbb5577.verified.txt index 5900015d5a..fdf3ac1aa9 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_8ea187616dbb5577.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_8ea187616dbb5577.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_905845c29560a3ef.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_905845c29560a3ef.verified.txt index 63f0da701c..ab7da96e44 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_905845c29560a3ef.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_905845c29560a3ef.verified.txt @@ -9,7 +9,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_b2fd24fab5b80917.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_b2fd24fab5b80917.verified.txt index d93aac7dc6..320c1983da 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_b2fd24fab5b80917.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_b2fd24fab5b80917.verified.txt @@ -10,7 +10,7 @@ Rest: { Enabled: false, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_bd7cd088755287c9.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_bd7cd088755287c9.verified.txt index d93aac7dc6..320c1983da 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_bd7cd088755287c9.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_bd7cd088755287c9.verified.txt @@ -10,7 +10,7 @@ Rest: { Enabled: false, Path: /api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d2eccba2f836b380.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d2eccba2f836b380.verified.txt index 75613db959..75df604b4e 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d2eccba2f836b380.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d2eccba2f836b380.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d463eed7fe5e4bbe.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d463eed7fe5e4bbe.verified.txt index 5900015d5a..fdf3ac1aa9 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d463eed7fe5e4bbe.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d463eed7fe5e4bbe.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d5520dd5c33f7b8d.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d5520dd5c33f7b8d.verified.txt index 75613db959..75df604b4e 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d5520dd5c33f7b8d.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_d5520dd5c33f7b8d.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_eab4a6010e602b59.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_eab4a6010e602b59.verified.txt index f7de35b7ae..eccdef1309 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_eab4a6010e602b59.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_eab4a6010e602b59.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_ecaa688829b4030e.verified.txt b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_ecaa688829b4030e.verified.txt index 5900015d5a..fdf3ac1aa9 100644 --- a/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_ecaa688829b4030e.verified.txt +++ b/src/Cli.Tests/Snapshots/InitTests.VerifyCorrectConfigGenerationWithMultipleMutationOptions_ecaa688829b4030e.verified.txt @@ -6,7 +6,7 @@ Rest: { Enabled: true, Path: /rest-api, - RequestBodyStrict: true + RequestBodyStrict: false }, GraphQL: { Enabled: true, diff --git a/src/Cli/Commands/InitOptions.cs b/src/Cli/Commands/InitOptions.cs index e01ad1b774..7fb9d66311 100644 --- a/src/Cli/Commands/InitOptions.cs +++ b/src/Cli/Commands/InitOptions.cs @@ -135,7 +135,7 @@ public InitOptions( // Since the rest.request-body-strict option does not have a default value, it is required to specify a value for this option if it is // included in the init command. - [Option("rest.request-body-strict", Required = false, HelpText = "(Default: true) Allow extraneous fields in the request body for REST.")] + [Option("rest.request-body-strict", Required = false, HelpText = "(Default: false) Allow extraneous fields in the request body for REST.")] public CliBool RestRequestBodyStrict { get; } [Option("graphql.multiple-create.enabled", Required = false, HelpText = "(Default: false) Enables multiple create operation for GraphQL. Supported values: true, false.")] diff --git a/src/Cli/ConfigGenerator.cs b/src/Cli/ConfigGenerator.cs index 9a3401a55a..bceb3936ef 100644 --- a/src/Cli/ConfigGenerator.cs +++ b/src/Cli/ConfigGenerator.cs @@ -262,7 +262,7 @@ public static bool TryCreateRuntimeConfig(InitOptions options, FileSystemRuntime Schema: dabSchemaLink, DataSource: dataSource, Runtime: new( - Rest: new(restEnabled, restPath ?? RestRuntimeOptions.DEFAULT_PATH, options.RestRequestBodyStrict is CliBool.False ? false : true), + Rest: new(restEnabled, restPath ?? RestRuntimeOptions.DEFAULT_PATH, options.RestRequestBodyStrict is CliBool.True ? true : false), GraphQL: new(Enabled: graphQLEnabled, Path: graphQLPath, MultipleMutationOptions: multipleMutationOptions), Mcp: new(mcpEnabled, mcpPath ?? McpRuntimeOptions.DEFAULT_PATH), Host: new( diff --git a/src/Config/ObjectModel/RestRuntimeOptions.cs b/src/Config/ObjectModel/RestRuntimeOptions.cs index 75ac20d610..df739d9162 100644 --- a/src/Config/ObjectModel/RestRuntimeOptions.cs +++ b/src/Config/ObjectModel/RestRuntimeOptions.cs @@ -10,8 +10,8 @@ namespace Azure.DataApiBuilder.Config.ObjectModel; /// The URL prefix path at which endpoints /// for all entities will be exposed. /// Boolean property indicating whether extraneous fields are allowed in request body. -/// The default value is true - meaning we don't allow extraneous fields by default in the rest request body. -/// Changing the default value is a breaking change. +/// The default value for existing configs (without this property set) is true - meaning we don't allow extraneous fields by default. +/// When dab init generates a new config, the default is false - allowing extraneous fields by default for a smoother development experience. public record RestRuntimeOptions(bool Enabled = true, string Path = RestRuntimeOptions.DEFAULT_PATH, bool RequestBodyStrict = true) { public const string DEFAULT_PATH = "/api";