Missing endpoint parameter referenced in generated output

[xirzec]

Having an issue where the generated output from https://github.com/Azure/azure-rest-api-specs-pr/pull/26801 does not compile properly.

The endpoint is defined in what appears to be a standard fashion:

@armProviderNamespace
@service(#{ title: "NetworkCloud" })
@server(
  "{endpoint}",
  "Azure ARM endpoint",
  {
    endpoint: url,
  }
)
@versioned(Versions)
namespace Microsoft.NetworkCloud;

Yet the generated code seems to be missing the endpointParam despite it still being referenced:

/** The Network Cloud APIs provide management of the Azure Operator Nexus compute resources such as on-premises clusters, hardware resources, and workload infrastructure resources. */
export function createNetworkCloud(
  credential: TokenCredential,
  subscriptionId: string,
  options: NetworkCloudClientOptionalParams = {},
): NetworkCloudContext {
  const endpointUrl =
    options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? String(endpointParam);

Looks like this is resolved in

autorest.typescript/packages/typespec-ts/src/modular/helpers/clientHelpers.ts

Line 182 in 5ead126

// We have been calling this endpointParam, so special handling this here to make sure there are no unexpected side effects

My guess it that the recent bump of TCGC (#3759) introduced some change to how this endpoint union gets constructed.

[xirzec]

Removing the @server decorator fixes the compile issue:

const endpointUrl =
    options.endpoint ?? getArmEndpoint(options.cloudSetting) ?? "https://management.azure.com";

[v-jiaodi]

For ARM package, endpoint comes from the default value provided by TCGC. If you use @server, you should give it a default value, e.g. @server("https://management.azure.com"), because the endpoint for ARM resources is fixed and we don’t want users to enter it manually. If clientDefaultValue === undefined, then defaultValueStr is equal to String(endpointParam)
https://github.com/Azure/autorest.typescript/blob/main/packages/typespec-ts/src/modular/helpers/clientHelpers.ts#L249

const clientDefaultValue =
        endpointParam.type.templateArguments[0]?.clientDefaultValue;
      const defaultValueStr =
        clientDefaultValue && typeof clientDefaultValue === "string"
          ? `"${clientDefaultValue}"`
          : clientDefaultValue
            ? clientDefaultValue
            : `String(${getClientParameterName(endpointParam)})`;

export function getClientParameterName(parameter: SdkParameter) {
  // We have been calling this endpointParam, so special handling this here to make sure there are no unexpected side effects
  if (
    (parameter.type.kind === "union" &&
      parameter.type.variantTypes.some((v) => v.kind === "endpoint")) ||
    ((parameter.kind === "endpoint" || parameter.kind === "path") &&
      parameter.name.toLowerCase() === "endpoint")
  ) {
    return "endpointParam";
  }

  return normalizeName(parameter.name, NameType.Parameter, true);
}

For non-ARM services, we need to provide/enter the endpoint:
case: https://github.com/Azure/autorest.typescript/blob/main/packages/typespec-test/test/chatApi_modular/generated/typespec-ts/src/api/chatProtocolContext.ts#L15

export function createChatProtocol(
  endpointParam: string,
  credential: KeyCredential | TokenCredential,
  options: ChatProtocolClientOptionalParams = {},
): ChatProtocolContext {
  const endpointUrl = options.endpoint ?? String(endpointParam);
  const prefixFromOptions = options?.userAgentOptions?.userAgentPrefix;

[qiaozha]

@xirzec do you still need more input on this?

[lirenhe]

Close it as no action needed.