Improve macOS emulator launch handling with retries and snapshot options

Author: mdshakib007

Framework/install_handler/android/emulator.py

@@ -356,22 +356,51 @@ def _spawn_emulator(cmd: list[str]) -> subprocess.Popen:
                     env=env
                 )
 
-        # Try launch with explicit sdk-root first.
-        process = _spawn_emulator([emulator_path, "-avd", avd_name, "-sdk-root", str(sdk_root)])
-        await asyncio.sleep(3)
-        returncode = process.poll()
+        async def _attempt_launch(cmd: list[str], wait_seconds: int, attempt_label: str) -> tuple[subprocess.Popen, int | None]:
+            process = _spawn_emulator(cmd)
+            await asyncio.sleep(wait_seconds)
+            returncode = process.poll()
+            if returncode is not None and debug:
+                launch_hint = _read_file_tail(log_path)
+                print(
+                    f"[installer][emulator] Launch attempt '{attempt_label}' exited (code {returncode}) "
+                    f"after {wait_seconds}s. Hint: {launch_hint[:300]}"
+                )
+            return process, returncode
+
+        # On macOS, emulator can fail a few seconds later on first-ever launch.
+        probe_seconds = 12 if _is_darwin() else 3
 
-        # macOS compatibility: retry without -sdk-root if first launch exits immediately.
+        # Attempt 1: explicit sdk-root
+        process, returncode = await _attempt_launch(
+            [emulator_path, "-avd", avd_name, "-sdk-root", str(sdk_root)],
+            probe_seconds,
+            "with-sdk-root",
+        )
+
+        # Attempt 2 (macOS): fallback without -sdk-root
         if returncode is not None and _is_darwin():
             if debug:
-                print("[installer][emulator] Emulator exited quickly with -sdk-root on macOS. Retrying without -sdk-root.")
-            process = _spawn_emulator([emulator_path, "-avd", avd_name])
-            await asyncio.sleep(3)
-            returncode = process.poll()
+                print("[installer][emulator] Retrying launch without -sdk-root on macOS.")
+            process, returncode = await _attempt_launch(
+                [emulator_path, "-avd", avd_name],
+                probe_seconds,
+                "without-sdk-root",
+            )
+
+        # Attempt 3 (macOS): disable snapshot loading on initial cold launch edge-cases
+        if returncode is not None and _is_darwin():
+            if debug:
+                print("[installer][emulator] Retrying launch with -no-snapshot-load on macOS.")
+            process, returncode = await _attempt_launch(
+                [emulator_path, "-avd", avd_name, "-no-snapshot-load"],
+                probe_seconds,
+                "no-snapshot-load",
+            )
 
         if returncode is not None:
             launch_hint = _read_file_tail(log_path)
-            error_msg = f"Emulator process for {avd_name} exited immediately (code {returncode})."
+            error_msg = f"Emulator process for {avd_name} exited during startup (code {returncode})."
             if launch_hint:
                 error_msg += f" Output hint: {launch_hint[:500]}"
             print(f"[installer][emulator] {error_msg}")