pipelineID is not resolved for existing pipeline when multiple pipeline stages are used

[milindcq]

Pre Requisites

• Put an X between the brackets on this line if you have done all of the following:
  • Checked the FAQs on the message board for common solutions:
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Autodesk

Description

While rendering a nested pipeline If one of the pipeline stage is a nested pipeline and another refers to an existing pipeline. The spinnaker pipeline id for the existing pipeline stage is not resolved. This is due to faulty check that skips the id resolution due to this check (

shore/pkg/backend/spinnaker/backend.go

Line 751 in 567fcf5

if !hasChildPipelines && mapContainsKey(innerStage, "application") && mapContainsKey(innerStage, "pipeline") && reflect.TypeOf(innerStage["pipeline"]).Kind() == reflect.String {

))

For example: In the nested pipeline in the image below (which is linked by the main application pipeline), the Redner stage refers to an existing pipeline while the Deploy stage that follows it is a nested pipeline. In the second image you can see that shore did not resolve the id of the Render pipeline (which was set to null).

Pipeline line Is was not resolved instead set to null.

Steps to Reproduce

1. The existing test pipeline is a good example (

   shore/pkg/backend/spinnaker/backend_test.go

   Line 834 in 567fcf5

   "pipeline": "Finding Pipeline nested"

   ) where function findAndReplacePipelineNameWithFoundID (

   shore/pkg/backend/spinnaker/backend.go

   Line 154 in 567fcf5

   func (s *SpinClient) findAndReplacePipelineNameWithFoundID(spinnakerObject map[string]interface{}) (bool, map[string]interface{}) {

   ) never gets called to resolve pipeline id for pipeline: "Finding Pipeline nested"

Expected behavior:

The pipeline stage pointing to an existing should have have pipeline id resolved.

Actual behavior:

The pipeline stage pointing to an existing should have have pipeline id resolved to null.

Reproduces how often:

100%

Versions

Additional Information