Summary
The investigation protocol involves: diagnostic question → block → re-submit → investigation plan → ExitPlanMode → investigate → findings → EnterPlanMode for fix → code-change plan. The test suite tests investigation mode activation and tool blocking, but not the full cycle including the transition to a subsequent code-change plan.
Motivation
The specific risk: does clear_workflow_keys properly reset diagnostic_mode when EnterPlanMode fires for the fix cycle? clear_workflow_keys includes diagnostic_mode in its key list, so it should work — but it's not tested end-to-end.
Proposed Change
Add an end-to-end test covering the full investigation → code-change plan transition:
- Activate investigation mode
- Complete investigation
- Enter plan mode for fix
- Verify
diagnostic_mode is properly reset
- Verify code-change plan workflow works normally after investigation
Acceptance Criteria
- Full investigation → code-change cycle is tested end-to-end
diagnostic_mode reset is verified at each transition point- Test passes with current implementation (validates existing behavior)
Summary
The investigation protocol involves: diagnostic question → block → re-submit → investigation plan → ExitPlanMode → investigate → findings → EnterPlanMode for fix → code-change plan. The test suite tests investigation mode activation and tool blocking, but not the full cycle including the transition to a subsequent code-change plan.
Motivation
The specific risk: does
clear_workflow_keysproperly resetdiagnostic_modewhenEnterPlanModefires for the fix cycle?clear_workflow_keysincludesdiagnostic_modein its key list, so it should work — but it's not tested end-to-end.Proposed Change
Add an end-to-end test covering the full investigation → code-change plan transition:
diagnostic_modeis properly resetAcceptance Criteria
diagnostic_modereset is verified at each transition point