Questionable copyright notices in image_u8_parallel

[oseiskar]

Who is the copyright holder of the code in image_u8_parallel (and related files)? April Robotics, University of Michigan, or @MqCreaple ? And has @MqCreaple given his permission to license this code under BSD 2? If yes, it would be best to remove these copyright notices or replace them with the same BSD 2 as in other files.

apriltag/common/image_u8_parallel.c

Lines 1 to 10 in 152eee7

	/**
	* @file image_u8_parallel.c
	* @author MqCreaple (gmq14159@gmail.com)
	* @brief Parallelized processing of various image_u8 related functions.
	* @version 0.1
	* @date 2025-08-07
	*
	* @copyright Copyright (c) 2025
	*
	*/

[christian-rauch]

The repo and its files are distributed under the "BSD 2-Clause License". Anyone can still be the copyright holder to the code they contributed. AFAIK, copyright attribution and licensing conditions are separate things.

But I agree that it is somewhat confusing having different copyright, version, author stanzas in the files.

[christian-rauch]

@MqCreaple Can you send a PR and remove this?

[MqCreaple]

Oh sorry, I will remove this copyright declaration now. Should I copy the copyright declarations from other files directly to the front of these two files?

/* Copyright (C) 2013-2016, The Regents of The University of Michigan.
All rights reserved.
This software was developed in the APRIL Robotics Lab under the
direction of Edwin Olson, ebolson@umich.edu. This software may be
available under alternative licensing terms; contact the address above.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice, this
   list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright notice,
   this list of conditions and the following disclaimer in the documentation
   and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
The views and conclusions contained in the software and documentation are those
of the authors and should not be interpreted as representing official policies,
either expressed or implied, of the Regents of The University of Michigan.
*/

[christian-rauch]

Yes, I would just use the same comments from the other related files (image_u8.h, ...) with an updated year.

[christian-rauch]

Fixed by #442.

[oseiskar]

Excellent! Thank you for the fixing this very quickly