Feedback 7/1

[giorgostheo]

Server-Client

---

Things that should be fixed:

• Server should not "hang" after a response to a specific connection. Currently after one query, the server drops the connection and waits for a new one.
• Whenever a connection is dropped (either as described above or by the user ex. ctrl-c), the port needs to be freed.

Things i would like to see:

• Client should be able to create databases too. Currently, a database in statically created/loaded. This should be user specified - not only vsmdb (if implementing the creation of a database by the client is too hard).
• Multiple clients should be able to connect and be served by the server.
• Client commands should be sql-like. Given an sql compiler has been implemented, the compiler should be used to parse the commands on the server side and return results.

SQL compiler

---

Things that should be fixed:

• Document the commands that you support (list of commands and syntax).

Things i would like to see:

• A compiler should be able to be easily expanded and built upon. Currently the source code is very static. This makes the process of adding support for more queries difficult. Theoretically a abstract syntax tree (AST) should be created etc. This concept is quite advanced. The code should at least be able to support some abstractions (functions that process operators, commands and objects). Handling the argument that parses the name of a table should be a function. Handling the initial command (select, insert etc) should also be a function. Dictionaries should probably be used to map states to functions in order to make expanding the compiler easier.

[AnthonyKalampogias]

Thank you for the feedback,
For the Server-Client part that I am responsible I will need more information on what you mean with Server should not "hang" after a response to a specific connection as for a fact I know that a server must await a connection on the specified port until someone requests something from the server, as for a fact the port is able to handle more than one connection refer to photo-1

Also the port is actually available but when there is an inbound connection the server will use it

And from this source I see that TIME_WAIT indicates that local endpoint (this side) has closed the connection
Source
Unless I haven't understood the argument, in that case please provide me with more information.

I have also improved the code so now a client has the ability to create a database as well, thank you for the notice! 88d15f1

As for the SQL Compiler Theodore has been notified about it and will return with a response in a sort while

Thank you.

[giorgostheo]

I meant that a specific client should be able to run multiple queries, one after another. Currently, after one sql command, the client drops the connection and exits (if i remember correctly). Internally, the connection might not remain open constantly, but the user should have to open a new client process for every query.

[AnthonyKalampogias]

Thank you for the heads up, I implemented some of the changes that you suggested, specifically the server now will handle more than one queries from each client, you can find the changes I made here 96284f3 .
In the following days we will also make the changes to the SQL Compiler as well.
Thank you for your feedback.

[theohrlp]

Implemented the SQL compiler to the Server-Client part of the code.
The changes i made can be found in the commit 51a09cf.
I made some more (minor) changes as well, hence the 2 more commits after the above mentioned one.
Thanks for your feedback.

[giorgostheo]

OK

Can you please add a small pdf documentation with some execution examples (screenshots primarily) as well as a paragraph stating what was added. A couple paragraphs and some screenshots will be enough (no need for something too extensive).

Good effort

[theohrlp]

Here is the pdf documentation that you requested, if you need anything else please don't hesitate to tell us about it.

Documentation.pdf