The README says Windows is not supported. Locally I did a port with pretty minor changes to make everything fully cross-platform. Is this something you would be interested in?
Rough list of things that needed to change:
- Gate
os.chmod in git hook installation
- Use
encoding="utf-8" everywhere explicitly
- Specify
newline="\n" for generated artifacts (otherwise you will get CRLF on Windows and LF on Unix)
- There are a lot of
Path.write_text which needed to be rewritten to Path.write_bytes because your pyproject.toml lists Python 3.9 as the minimum version and newline="\n" was added in 3.10. Your CI tests from 3.10 onwards, so bumping could simplify a lot.
- Remove reliance on
shell=True in a few places (cd tmp && xxx replaced with cwd=tmp)
- Handle quarto installation through
winget on Windows
- Minor changes to get the tests to run correctly
There are some dependencies that could use the newline parameter for writing (nb_write) and then everything would be consistent across platforms.
The README says Windows is not supported. Locally I did a port with pretty minor changes to make everything fully cross-platform. Is this something you would be interested in?
Rough list of things that needed to change:
os.chmodin git hook installationencoding="utf-8"everywhere explicitlynewline="\n"for generated artifacts (otherwise you will get CRLF on Windows and LF on Unix)Path.write_textwhich needed to be rewritten toPath.write_bytesbecause yourpyproject.tomllists Python 3.9 as the minimum version andnewline="\n"was added in 3.10. Your CI tests from 3.10 onwards, so bumping could simplify a lot.shell=Truein a few places (cd tmp && xxxreplaced withcwd=tmp)wingeton WindowsThere are some dependencies that could use the newline parameter for writing (nb_write) and then everything would be consistent across platforms.