Merge pull request #128 from AltaPay/fix-order-status-issue

Fix: Apple Pay orders are marked as Processing even when the payment fails

Author: emicha

CHANGELOG.md

@@ -1,6 +1,9 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [3.8.6]
+- Fix: Apple Pay orders are marked as Processing even when the payment fails.
+
 ## [3.8.5]
 - Support gateway form independent of the plugin/theme styling.
 

altapay.php

@@ -7,10 +7,10 @@
  * Author URI: https://altapay.com
  * Text Domain: altapay
  * Domain Path: /languages
- * Version: 3.8.5
+ * Version: 3.8.6
  * Name: SDM_Altapay
  * WC requires at least: 3.9.0
- * WC tested up to: 10.2.2
+ * WC tested up to: 10.4.3
  *
  * @package Altapay
  */
@@ -41,7 +41,7 @@
 }
 
 if ( ! defined( 'ALTAPAY_PLUGIN_VERSION' ) ) {
-	define( 'ALTAPAY_PLUGIN_VERSION', '3.8.5' );
+	define( 'ALTAPAY_PLUGIN_VERSION', '3.8.6' );
 }
 
 // Include the autoloader, so we can dynamically include the rest of the classes.

classes/core/ApplePay.php

@@ -184,12 +184,10 @@ public function applepay_card_wallet_authorize() {
 			$txn_id             = $transaction['TransactionId'];
 
 			$order->add_order_note( __( "Gateway Order ID: $order_id", 'altapay' ) );
-			$order->add_order_note( __( 'Apple Pay payment completed', 'altapay' ) );
-			$order->payment_complete();
-			$order->set_transaction_id( $txn_id );
-			$order->save();
-
 			if ( $response->Result === 'Success' ) {
+				$order->set_transaction_id( $txn_id );
+				$order->add_order_note( __( 'Apple Pay payment completed', 'altapay' ) );
+				$order->payment_complete();
 
 				$reconciliation = new Core\AltapayReconciliation();
 				foreach ( $transaction['ReconciliationIdentifiers'] as $val ) {

readme.txt

@@ -4,10 +4,10 @@ Tags: AltaPay, Gateway, Payments, WooCommerce, Payment Card Industry
 Requires PHP: 7.4
 Requires at least: 5.0
 Tested up to: 6.8.2
-Stable tag: 3.8.5
+Stable tag: 3.8.6
 License: MIT
 WC requires at least: 3.9.0
-WC tested up to: 10.2.2
+WC tested up to: 10.4.3
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
 A plugin that integrates your WooCommerce web shop to the AltaPay payments gateway.
@@ -39,6 +39,9 @@ AltaPay's Payment Gateway for WooCommerce provides merchants with access to a fu
 
 == Changelog ==
 
+= 3.8.6 =
+* Fix: Apple Pay orders are marked as Processing even when the payment fails.
+
 = 3.8.5 =
 * Support gateway form independent of the plugin/theme styling.
 

wiki.md

@@ -316,14 +316,14 @@ The new credentials can now be used as the API Username and API Password in your
 ## Supported versions
 
 Minimum system requirements are:
-- WordPress min. 5.0 – max. 6.8.2
-- WooCommerce min. 3.9.0 – max. 10.2.2
+- WordPress min. 5.0 – max. 6.9
+- WooCommerce min. 3.9.0 – max. 10.4.3
 - PHP 7.4 and above
 - PHP-bcmath library installed.
 - PHP-curl MUST be enabled.
 
 The latest tested version is:
-- WordPress 6.8.2, WooCommerce 10.2.2 and PHP 8.4
+- WordPress 6.9, WooCommerce 10.4.3 and PHP 8.4
 
 
 ## Troubleshooting