Make sure the ROF IR is decoded, otherwise abort link data

Author: shahor02

Detectors/ITSMFT/common/reconstruction/include/ITSMFTReconstruction/GBTLink.h

@@ -39,7 +39,7 @@
   }                                                                           \
   if ((errRes)&uint8_t(Abort)) {                                              \
     discardData();                                                            \
-    return AbortedOnError;                                                    \
+    return (status = AbortedOnError);                                         \
   }
 
 namespace o2
@@ -187,6 +187,8 @@ struct GBTLink {
   uint8_t checkErrorsDiagnosticWord(const GBTDiagnostic* gbtD) const { return NoError; }
   uint8_t checkErrorsCalibrationWord(const GBTCalibration* gbtCal) const { return NoError; }
   uint8_t checkErrorsCableID(const GBTData* gbtD, uint8_t cableSW) const { return NoError; }
+  uint8_t checkErrorsIRNotExtracted() const { return NoError; }
+
 #else
   uint8_t checkErrorsAlignmentPadding();
   uint8_t checkErrorsRDH(const RDH& rdh);
@@ -203,6 +205,8 @@ struct GBTLink {
   uint8_t checkErrorsDiagnosticWord(const GBTDiagnostic* gbtD);
   uint8_t checkErrorsCalibrationWord(const GBTCalibration* gbtCal);
   uint8_t checkErrorsCableID(const GBTData* gbtD, uint8_t cableSW);
+  uint8_t checkErrorsIRNotExtracted();
+
 #endif
   uint8_t checkErrorsGBTDataID(const GBTData* dbtD);
 
@@ -339,7 +343,10 @@ GBTLink::CollectedDataStatus GBTLink::collectROFCableData(const Mapping& chmap)
         }
         continue;
       }
+      // trigger is supposed to be seen
+      GBTLINK_DECODE_ERRORCHECK(errRes, checkErrorsIRNotExtracted());
     }
+
     auto gbtD = reinterpret_cast<const o2::itsmft::GBTData*>(&currRawPiece->data[dataOffset]);
     expectPacketDone = true;
 

Detectors/ITSMFT/common/reconstruction/src/GBTLink.cxx

@@ -510,6 +510,23 @@ uint8_t GBTLink::checkErrorsCableID(const GBTData* gbtD, uint8_t cableSW)
   return err;
 }
 
+///_________________________________________________________________
+/// Check that the IR was extracted from the trigger
+uint8_t GBTLink::checkErrorsIRNotExtracted()
+{
+  uint8_t err = uint8_t(NoError);
+  if (ir.isDummy()) {
+    statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTTrigger]++;
+    gbtErrStatUpadated = true;
+    if (needToPrintError(statistics.errorCounts[GBTLinkDecodingStat::ErrMissingGBTTrigger])) {
+      LOG(info) << describe() << " IR_RDH " << irHBF << " IR_ROF " << ir << ". " << statistics.ErrNames[GBTLinkDecodingStat::ErrMissingGBTTrigger];
+    }
+    errorBits |= 0x1 << int(GBTLinkDecodingStat::ErrMissingGBTTrigger);
+    err |= uint8_t(Abort);
+  }
+  return err;
+}
+
 ///_________________________________________________________________
 /// Account link recovery RDH flag
 void GBTLink::accountLinkRecovery(o2::InteractionRecord ir)