Refactor nameplate system to improve synchronization and modularity

- Moved team setup logic to `StylingModule` for reusability.
- Added `reloadNameplates` method with scheduled updates.
- Simplified mixin implementation with `ModuleProvider.STYLING`.
- Annotated `CustomPlayerTeam` with `@MethodsReturnNonnullByDefault`.

Author: Ale32bit

src/main/java/me/alexdevs/solstice/mixin/modules/styling/CustomNameplateMixin.java

@@ -1,7 +1,6 @@
 package me.alexdevs.solstice.mixin.modules.styling;
 
-import me.alexdevs.solstice.modules.styling.CustomPlayerTeam;
-import net.minecraft.network.protocol.game.ClientboundSetPlayerTeamPacket;
+import me.alexdevs.solstice.modules.ModuleProvider;
 import net.minecraft.server.ServerScoreboard;
 import net.minecraft.server.level.ServerPlayer;
 import net.minecraft.server.players.PlayerList;
@@ -23,10 +22,7 @@ public abstract class CustomNameplateMixin {
 
     @Inject(method = "updateEntireScoreboard", at = @At("HEAD"))
     private void solstice$overrideNameplate(ServerScoreboard scoreboard, ServerPlayer player, CallbackInfo ci) {
-        for (var otherPlayer : players) {
-            var team = new CustomPlayerTeam(scoreboard, otherPlayer);
-            player.connection.send(ClientboundSetPlayerTeamPacket.createAddOrModifyPacket(team, true));
-        }
+        ModuleProvider.STYLING.sendTeamSetup(player, players, scoreboard, true);
     }
 
 }

src/main/java/me/alexdevs/solstice/modules/styling/CustomPlayerTeam.java

@@ -2,17 +2,16 @@
 
 import me.alexdevs.solstice.modules.ModuleProvider;
 import net.minecraft.ChatFormatting;
+import net.minecraft.MethodsReturnNonnullByDefault;
 import net.minecraft.network.chat.Component;
-import net.minecraft.network.chat.TextColor;
 import net.minecraft.server.level.ServerPlayer;
 import net.minecraft.world.scores.PlayerTeam;
 import net.minecraft.world.scores.Scoreboard;
 
 import java.util.Collection;
 import java.util.List;
-import java.util.Map;
-import java.util.stream.Collectors;
 
+@MethodsReturnNonnullByDefault
 public class CustomPlayerTeam extends PlayerTeam {
     private final ServerPlayer player;
 
@@ -23,6 +22,10 @@ public CustomPlayerTeam(Scoreboard scoreboard, ServerPlayer player) {
         super.getPlayers().add(player.getGameProfile().getName());
     }
 
+    @Override
+    public Component getDisplayName() {
+        return player.getDisplayName();
+    }
 
     @Override
     public ChatFormatting getColor() {

src/main/java/me/alexdevs/solstice/modules/styling/StylingModule.java

@@ -10,9 +10,14 @@
 import me.lucko.fabric.api.permissions.v0.Permissions;
 import net.minecraft.ChatFormatting;
 import net.minecraft.network.chat.Component;
+import net.minecraft.network.protocol.game.ClientboundSetPlayerTeamPacket;
 import net.minecraft.resources.ResourceLocation;
 import net.minecraft.server.level.ServerPlayer;
 import net.minecraft.server.players.PlayerList;
+import net.minecraft.world.scores.Scoreboard;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
 
 public class StylingModule extends ModuleBase.Toggleable {
     public static final String ADVANCED_CHAT_FORMATTING_PERMISSION = "solstice.chat.advanced";
@@ -49,13 +54,9 @@ public void init() {
             }
         });
 
-        SolsticeEvents.RELOAD.register(instance -> {
-            var playerList = Solstice.server.getPlayerList();
-            var scoreboard = Solstice.server.getScoreboard();
-            for (var player : playerList.getPlayers()) {
-                playerList.updateEntireScoreboard(scoreboard, player);
-            }
-        });
+        SolsticeEvents.RELOAD.register(instance -> reloadNameplates(false));
+
+        Solstice.scheduler.scheduleAtFixedRateSync(() -> reloadNameplates(false), 0, 1, TimeUnit.SECONDS);
     }
 
     public StylingConfig getConfig() {
@@ -128,4 +129,22 @@ public Component getNameplateSuffix(ServerPlayer player) {
 
         return Format.parse(format, PlaceholderContext.of(player));
     }
+
+    private void reloadNameplates(boolean add) {
+        var playerList = Solstice.server.getPlayerList();
+        var scoreboard = Solstice.server.getScoreboard();
+        for (var player : playerList.getPlayers()) {
+            sendTeamSetup(player, playerList.getPlayers(), scoreboard, add);
+        }
+    }
+
+    public void sendTeamSetup(ServerPlayer player, List<ServerPlayer> players, Scoreboard scoreboard, boolean add) {
+        for (var otherPlayer : players) {
+            if(otherPlayer == player) {
+                continue;
+            }
+            var team = new CustomPlayerTeam(scoreboard, otherPlayer);
+            player.connection.send(ClientboundSetPlayerTeamPacket.createAddOrModifyPacket(team, add));
+        }
+    }
 }