From 9a148a9bdc789b82243dc3ad2a6c0d68240358f2 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Fri, 1 May 2026 22:16:29 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Palette:=20Fix=20QuickPick=20stu?= =?UTF-8?q?ck=20in=20loading=20state=20when=20clearing=20history?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 💡 What: Added `quickPick.busy = false` before displaying the confirm/cancel dialog for clearing recent history. 🎯 Why: If a user initiated a "Clear History" action, any active loading state from previous searches remained visible while waiting for confirmation, creating a confusing UI state where it appeared the app was still searching. 📸 Before/After: Visual-only improvement in the VS Code QuickPick modal. ♿ Accessibility: Reduces cognitive load by ensuring visual indicators accurately reflect system state. Co-authored-by: AhmmedSamier <17784876+AhmmedSamier@users.noreply.github.com> --- .jules/palette.md | 3 +++ vscode-extension/src/search-provider.ts | 2 ++ 2 files changed, 5 insertions(+) create mode 100644 .jules/palette.md diff --git a/.jules/palette.md b/.jules/palette.md new file mode 100644 index 00000000..1853ae6c --- /dev/null +++ b/.jules/palette.md @@ -0,0 +1,3 @@ +## 2024-05-24 - QuickPick busy state reset +**Learning:** For VS Code extension `QuickPick` elements, if an interaction (e.g. prompt rendering) is short-circuited or handles a terminal modal action (like a confirmation), `quickPick.busy = false` must be explicitly set before presenting the modal, otherwise it will remain visually stuck in the loading state from a previous search. +**Action:** Always verify `quickPick.busy` is cleanly reset before rendering standalone prompts or static confirm/cancel lists within the same UI instance. diff --git a/vscode-extension/src/search-provider.ts b/vscode-extension/src/search-provider.ts index 21e2b6aa..c2b4bc02 100644 --- a/vscode-extension/src/search-provider.ts +++ b/vscode-extension/src/search-provider.ts @@ -510,6 +510,8 @@ export class SearchProvider { * Prompt for confirmation before clearing history */ private promptClearHistory(quickPick: vscode.QuickPick): void { + quickPick.busy = false; + const confirmItem: SearchResultItem = { label: 'Confirm Clear History', detail: 'This cannot be undone',