From ea803bd2a102631a2fc041d31ca9832e71c1bc53 Mon Sep 17 00:00:00 2001 From: Akshay Gupta Date: Thu, 5 Mar 2026 10:16:55 +0000 Subject: [PATCH 1/2] misc: amd-apml: Refine APML I3C messages for TSI Clarify the I3C probe info message for non-TSI controllers Log static address 0 using dev_err instead of informational logging Reviewed-by: Naveen Krishna Chatradhi Signed-off-by: Akshay Gupta --- drivers/misc/amd-apml/apml_sbtsi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/misc/amd-apml/apml_sbtsi.c b/drivers/misc/amd-apml/apml_sbtsi.c index d4900ed4bd84fd..bab14551de2077 100644 --- a/drivers/misc/amd-apml/apml_sbtsi.c +++ b/drivers/misc/amd-apml/apml_sbtsi.c @@ -487,7 +487,8 @@ static int sbtsi_i3c_probe(struct i3c_device *i3cdev) dev_info(dev, "SBTSI: PID: %llx\n", i3cdev->desc->info.pid); if (!(I3C_PID_INSTANCE_ID(i3cdev->desc->info.pid) == 0 || i3cdev->desc->info.pid == 0x22400000001)) { - dev_info(dev, "SBTSI: Error PID: %llx\n", i3cdev->desc->info.pid); + dev_info(dev, "SBTSI: PID mismatch: 0x%llx not a TSI controller", + i3cdev->desc->info.pid); return -ENXIO; } @@ -514,8 +515,8 @@ static int sbtsi_i3c_probe(struct i3c_device *i3cdev) map_sbtsi_pid_to_static_addr(i3cdev, tsi_dev); if (tsi_dev->dev_static_addr == 0) { - dev_info(dev, "SBTSI: PID = 0x%llx, static address zero, skip the device\n", - i3cdev->desc->info.pid); + dev_err(dev, "SBTSI: PID = 0x%llx, static address zero, skip the device\n", + i3cdev->desc->info.pid); return -ENXIO; } From 44c2a282b725342b949c745bc3030dc38d4d165a Mon Sep 17 00:00:00 2001 From: Akshay Gupta Date: Thu, 5 Mar 2026 10:19:26 +0000 Subject: [PATCH 2/2] misc: amd-apml: Refine APML I3C messages for RMI Clarify the I3C probe info message for non-RMI controllers Log static address 0 using dev_err instead of informational logging Reviewed-by: Naveen Krishna Chatradhi Signed-off-by: Akshay Gupta --- drivers/misc/amd-apml/sbrmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/misc/amd-apml/sbrmi.c b/drivers/misc/amd-apml/sbrmi.c index 4c972ef00873e3..b669b07be4cb72 100644 --- a/drivers/misc/amd-apml/sbrmi.c +++ b/drivers/misc/amd-apml/sbrmi.c @@ -682,7 +682,8 @@ static int sbrmi_i3c_probe(struct i3c_device *i3cdev) if (!(I3C_PID_INSTANCE_ID(i3cdev->desc->info.pid) == 1 || i3cdev->desc->info.pid == 0x22400000002)) { - dev_info(dev, "SBRMI: PID Error: %llx\n", i3cdev->desc->info.pid); + dev_info(dev, "SBRMI: PID mismatch: 0x%llx not a RMI controller\n", + i3cdev->desc->info.pid); return -ENXIO; } @@ -705,8 +706,8 @@ static int sbrmi_i3c_probe(struct i3c_device *i3cdev) map_sbrmi_pid_to_static_addr(i3cdev, rmi_dev); if (rmi_dev->dev_static_addr == 0) { - dev_info(dev, "SBRMI: PID = 0x%llx, static address zero, skip the device\n", - i3cdev->desc->info.pid); + dev_err(dev, "SBRMI: PID = 0x%llx, static address zero, skip the device\n", + i3cdev->desc->info.pid); } hwmon_dev_name = devm_kasprintf(dev, GFP_KERNEL, "sbrmi_%s",